Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

diff --git a/cf/f95bb3e84257a6b4082c8357d9a7a2861368c2 b/cf/f95bb3e84257a6b4082c8357d9a7a2861368c2
new file mode 100644 (file)
index 0000000..43de260
--- /dev/null
+++ b/cf/f95bb3e84257a6b4082c8357d9a7a2861368c2
@@ -0,0 +1,109 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 394DF429E21\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 10:35:12 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 565pBRosG0Ju for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 10:35:11 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A0F8D431E64\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 10:35:11 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RrZak-0000vu-HE; Sun, 29 Jan 2012 18:35:06 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RrZak-0002sz-9y; Sun, 29 Jan 2012 18:35:06 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag\r
+In-Reply-To: <87zkd6pzg2.fsf@qmul.ac.uk>\r
+References: <20120124011609.GX16740@mit.edu>\r
+       <1327367923-18228-2-git-send-email-markwalters1009@gmail.com>\r
+       <20120124024521.GY16740@mit.edu> <874nvg6qxn.fsf@qmul.ac.uk>\r
+       <20120128183340.GD17991@mit.edu> <8739azqt2j.fsf@qmul.ac.uk>\r
+       <87zkd6pzg2.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.11+136~g15d04f0 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Sun, 29 Jan 2012 18:36:10 +0000\r
+Message-ID: <8762fu4aqt.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: bb79be8e6d7028fe15abdf6852e7d65d (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 29 Jan 2012 18:35:12 -0000\r
+\r
+\r
+Ok I now have a patch set which might be complete enough to be worth\r
+reviewing. It is essentially complete and appears to work.\r
+\r
+Things that still need doing: \r
+       updating the test suite. The series changes notmuch-show to\r
+       output the exclude flag so several tests need updating. Of\r
+       course, the new functionality needs some tests too.\r
+       \r
+       emacs/notmuch.el I think it would be nice to hide (make\r
+       invisible) threads with no matching non-excluded messages (with a\r
+       toggle for visibility) but that is definitely beyond my elisp\r
+       skills.\r
+\r
+The first patch of the series is not really part of the series: it adds\r
+a --do-not-exclude option to tell the command not to exclude. I think\r
+this is useful anyway, but it also simplifies behaviour decisions with\r
+the excludes. For example notmuch count will only count matching\r
+non-excluded messages but notmuch count --do-not-exclude will count \r
+all matching messages excluded or not.\r
+\r
+One outstanding issue is that raised in\r
+id:"20120124025331.GZ16740@mit.edu". I will need to think about\r
+that. \r
+\r
+Best wishes\r
+\r
+Mark\r
+\r