--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id D07C6431FC3\r
+ for <notmuch@notmuchmail.org>; Fri, 13 Jul 2012 11:43:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id U7AtCs89czgo for <notmuch@notmuchmail.org>;\r
+ Fri, 13 Jul 2012 11:43:13 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU\r
+ [18.9.25.12])\r
+ by olra.theworths.org (Postfix) with ESMTP id 110CA431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 13 Jul 2012 11:43:13 -0700 (PDT)\r
+X-AuditID: 1209190c-b7f806d000006b87-f9-50006c3e29f1\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+ by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 90.EB.27527.F3C60005; Fri, 13 Jul 2012 14:43:11 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q6DIhAmL010142; \r
+ Fri, 13 Jul 2012 14:43:10 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6DIh9iV020003\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Fri, 13 Jul 2012 14:43:09 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1SpkpY-0008D3-RJ; Fri, 13 Jul 2012 14:43:08 -0400\r
+Date: Fri, 13 Jul 2012 14:43:08 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 2/7] emacs: Use text properties instead of overlays for\r
+ tag coloring\r
+Message-ID: <20120713184308.GB31182@mit.edu>\r
+References: <1342140319-19859-1-git-send-email-amdragon@mit.edu>\r
+ <1342140319-19859-3-git-send-email-amdragon@mit.edu>\r
+ <877gu78ruk.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <877gu78ruk.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1rXPYQgwuLec2WL1XB6L6zdnMjsw\r
+ eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGUun32Up2Kla8eT8FfYGxkuyXYycHBICJhK7\r
+ f15jhrDFJC7cW8/WxcjFISSwj1Fi7e9uZghnA6PEy0+LmCCck0wS827fZodwljBKzPi8E6yf\r
+ RUBV4ueBV6wgNpuAhsS2/csZQWwRAR2J24cWsIPYzALSEt9+NwNN4uAQFoiS2Ho6AiTMC1Ry\r
+ 5fQhRoiZUxklTvzZyg6REJQ4OfMJC0SvlsSNfy/BekHmLP/HARLmBFrVPHU+G4gtKqAiMeXk\r
+ NrYJjEKzkHTPQtI9C6F7ASPzKkbZlNwq3dzEzJzi1GTd4uTEvLzUIl1DvdzMEr3UlNJNjOCw\r
+ luTZwfjmoNIhRgEORiUe3nR/hgAh1sSy4srcQ4ySHExKorw/M4FCfEn5KZUZicUZ8UWlOanF\r
+ hxglOJiVRHh1jIFyvCmJlVWpRfkwKWkOFiVx3sspN/2FBNITS1KzU1MLUotgsjIcHEoSvAnZ\r
+ QI2CRanpqRVpmTklCGkmDk6Q4TxAw4NAaniLCxJzizPTIfKnGBWlxHlngyQEQBIZpXlwvbC0\r
+ 84pRHOgVYd4wkCoeYMqC634FNJgJaPCsn//8gQaXJCKkpBoYk5++fXFC0cpWkMHi0P95saKR\r
+ GnpP7mU3s2Yy/I7z4W27EnPQ5NICD/5d+zur7EI6/R+cufvy+J34PpuvIc+m7JY2UTOVUuro\r
+ lf10oMri3ddd/9WzvrgInwpjmBe9LefgrdonFx9lFDFEHHZtidXk/X1curi91vPSSvG7kn8F\r
+ C6MV43Xkj2QqsRRnJBpqMRcVJwIARt2fIhYDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 13 Jul 2012 18:43:14 -0000\r
+\r
+Quoth Mark Walters on Jul 13 at 6:59 pm:\r
+> On Fri, 13 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Previously, tag-based search result highlighting was done by creating\r
+> > an overlay over each search result. However, overlays have annoying\r
+> > front- and rear-advancement semantics that make it difficult to\r
+> > manipulate text at their boundaries, which the next patch will do.\r
+> > They also have performance problems (creating an overlay is linear in\r
+> > the number of overlays between point and the new overlay, making\r
+> > highlighting a search buffer quadratic in the number of results).\r
+> >\r
+> > Text properties have neither problem. However, text properties make\r
+> > it more difficult to apply multiple faces since, unlike with overlays,\r
+> > a given character can only have a single 'face text property. Hence,\r
+> > we introduce a utility function that combines faces into any existing\r
+> > 'face text properties.\r
+> >\r
+> > Using this utility function, it's straightforward to apply all of the\r
+> > appropriate tag faces in notmuch-search-color-line.\r
+> \r
+> I have some recollection of people talking about text properties as\r
+> opposed to overlays some time ago but saying one problem was you\r
+> couldn't do invisibility with text properties. Is that correct and is it\r
+> a concern? (Otherwise it all looks good)\r
+\r
+I believe the problem was that isearch can only automatically expand\r
+invisible text that's marked invisible using overlays. Regardless,\r
+this shouldn't be an issue for this patch because invisibility and\r
+faces are controlled by different text properties. It also shouldn't\r
+be a problem for the next patch because, while we do use overlays to\r
+hide authors, that overlay should always be strictly within the search\r
+result (even if it's at the end of the result format, we'll follow it\r
+with a newline) and hence deleting the entire search result region\r
+should also delete the author invisibility overlay.\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+> > ---\r
+> > emacs/notmuch-lib.el | 15 +++++++++++++++\r
+> > emacs/notmuch.el | 21 +++++++--------------\r
+> > 2 files changed, 22 insertions(+), 14 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> > index aa25513..30db58f 100644\r
+> > --- a/emacs/notmuch-lib.el\r
+> > +++ b/emacs/notmuch-lib.el\r
+> > @@ -269,6 +269,21 @@ current buffer, if possible."\r
+> > (loop for (key value . rest) on plist by #'cddr\r
+> > collect (cons (intern (substring (symbol-name key) 1)) value)))\r
+> > \r
+> > +(defun notmuch-combine-face-text-property (start end face)\r
+> > + "Combine FACE into the 'face text property between START and END.\r
+> > +\r
+> > +This function combines FACE with any existing faces between START\r
+> > +and END. Attributes specified by FACE take precedence over\r
+> > +existing attributes. FACE must be a face name (a symbol or\r
+> > +string), a property list of face attributes, or a list of these."\r
+> > +\r
+> > + (let ((pos start))\r
+> > + (while (< pos end)\r
+> > + (let ((cur (get-text-property pos 'face))\r
+> > + (next (next-single-property-change pos 'face nil end)))\r
+> > + (put-text-property pos next 'face (cons face cur))\r
+> > + (setq pos next)))))\r
+> > +\r
+> > ;; Compatibility functions for versions of emacs before emacs 23.\r
+> > ;;\r
+> > ;; Both functions here were copied from emacs 23 with the following copyright:\r
+> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > index ef18927..82c148d 100644\r
+> > --- a/emacs/notmuch.el\r
+> > +++ b/emacs/notmuch.el\r
+> > @@ -633,20 +633,13 @@ foreground and blue background."\r
+> > \r
+> > (defun notmuch-search-color-line (start end line-tag-list)\r
+> > "Colorize lines in `notmuch-show' based on tags."\r
+> > - ;; Create the overlay only if the message has tags which match one\r
+> > - ;; of those specified in `notmuch-search-line-faces'.\r
+> > - (let (overlay)\r
+> > - (mapc (lambda (elem)\r
+> > - (let ((tag (car elem))\r
+> > - (attributes (cdr elem)))\r
+> > - (when (member tag line-tag-list)\r
+> > - (when (not overlay)\r
+> > - (setq overlay (make-overlay start end)))\r
+> > - ;; Merge the specified properties with any already\r
+> > - ;; applied from an earlier match.\r
+> > - (overlay-put overlay 'face\r
+> > - (append (overlay-get overlay 'face) attributes)))))\r
+> > - notmuch-search-line-faces)))\r
+> > + (mapc (lambda (elem)\r
+> > + (let ((tag (car elem))\r
+> > + (attributes (cdr elem)))\r
+> > + (when (member tag line-tag-list)\r
+> > + (notmuch-combine-face-text-property start end attributes))))\r
+> > + ;; Reverse the list so earlier entries take precedence\r
+> > + (reverse notmuch-search-line-faces)))\r
+> > \r
+> > (defun notmuch-search-author-propertize (authors)\r
+> > "Split `authors' into matching and non-matching authors and\r
projects / notmuch-archives.git / commitdiff