Re: [PATCH 2/2] emacs: Don't move to the next thread unless the cursor is at the...

diff --git a/1f/4d1f856116c01251984bae50c7a8c1a820b307 b/1f/4d1f856116c01251984bae50c7a8c1a820b307
new file mode 100644 (file)
index 0000000..649c757
--- /dev/null
+++ b/1f/4d1f856116c01251984bae50c7a8c1a820b307
@@ -0,0 +1,120 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D43B8431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:14:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kCAEVIr07EGu for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Apr 2012 10:14:47 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 19F23431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 10:14:47 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SJT28-0004lS-Du; Sun, 15 Apr 2012 18:14:42 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1SJT28-0002nB-2r; Sun, 15 Apr 2012 18:14:40 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the\r
+       cursor is at the end of the buffer.\r
+In-Reply-To: <1327996914-9644-3-git-send-email-dme@dme.org>\r
+References: <1327996914-9644-1-git-send-email-dme@dme.org>\r
+       <1327996914-9644-3-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 15 Apr 2012 18:14:59 +0100\r
+Message-ID: <87lilw6hnw.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 80510b1f8ce6ac3fabaf4e9ab3aa1233 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Apr 2012 17:14:48 -0000\r
+\r
+\r
+On Tue, 31 Jan 2012, David Edmondson <dme@dme.org> wrote:\r
+> When using the spacebar to scroll through a thread, hitting 'space'\r
+> when the bottom of the last message is visible should take the cursor\r
+> to the end of the buffer rather than immediately archiving the thread\r
+> and moving to the next thread.\r
+\r
+Hi\r
+\r
+This patch looks good to me; (but if people prefer the current behaviour then\r
+can we mark this notmuch::wontfix so it leaves the review queue)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> ---\r
+>  emacs/notmuch-show.el |    5 +++++\r
+>  1 files changed, 5 insertions(+), 0 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index ec72ff8..3f54de0 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1319,6 +1319,11 @@ current window), advance to the next open message."\r
+>        ;; This is not the last message - move to the next visible one.\r
+>        (notmuch-show-next-open-message))\r
+>  \r
+> +     ((not (= (point) (point-max)))\r
+> +      ;; This is the last message, but the cursor is not at the end of\r
+> +      ;; the buffer. Move it there.\r
+> +      (goto-char (point-max)))\r
+> +\r
+>       (t\r
+>        ;; This is the last message - change the return value\r
+>        (setq ret t)))\r
+> -- \r
+> 1.7.8.3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r