Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by default

diff --git a/15/1373b3d157a1fdc4d2228f43f60bca01910635 b/15/1373b3d157a1fdc4d2228f43f60bca01910635
new file mode 100644 (file)
index 0000000..bc6e9a7
--- /dev/null
+++ b/15/1373b3d157a1fdc4d2228f43f60bca01910635
@@ -0,0 +1,111 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 69C90431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:31:22 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ZJPVIpKB4qrJ for <notmuch@notmuchmail.org>;\r
+       Sun, 19 Feb 2012 09:31:21 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A55C9431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:31:21 -0800 (PST)\r
+Received: by bkcit16 with SMTP id it16so4630255bkc.26\r
+       for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:31:20 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com\r
+       designates 10.204.152.7 as permitted sender)\r
+       client-ip=10.204.152.7; \r
+Authentication-Results: mr.google.com; spf=pass (google.com: domain of\r
+       dmitry.kurochkin@gmail.com designates 10.204.152.7 as permitted\r
+       sender) smtp.mail=dmitry.kurochkin@gmail.com;\r
+       dkim=pass header.i=dmitry.kurochkin@gmail.com\r
+Received: from mr.google.com ([10.204.152.7])\r
+       by 10.204.152.7 with SMTP id e7mr9617915bkw.70.1329672680456 (num_hops\r
+       = 1); Sun, 19 Feb 2012 09:31:20 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=G3J8PuPfV9b+r5WaJfD8SrPFbJ7PIprwTMMgWbm0s/Y=;\r
+       b=baJOD5O0mN5sOpLSvc9e4m4Zi5BAfvnykIbP071V84MwYql7mDQXNvg5x1ZpZk/upT\r
+       dHC9Fdm2EU25YiSChisosQ5NhQV9AV7KWfulxQoKi+q7Lx47VVFN/6+MfgGLNL5c900O\r
+       ZpgUR0ZnOyHByRYAGeGdsTq1lZVGiORAQmyDk=\r
+Received: by 10.204.152.7 with SMTP id e7mr7800322bkw.70.1329672678892;\r
+       Sun, 19 Feb 2012 09:31:18 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id bw9sm34213369bkb.8.2012.02.19.09.31.17\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 19 Feb 2012 09:31:18 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by\r
+ default\r
+In-Reply-To: <20120219172541.GQ5991@mit.edu>\r
+References: <1329632533-16152-1-git-send-email-amdragon@mit.edu>\r
+       <m2k43jw43j.fsf@guru.guru-group.fi> <20120219172541.GQ5991@mit.edu>\r
+User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 19 Feb 2012 21:29:56 +0400\r
+Message-ID: <87zkceloiz.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 Feb 2012 17:31:22 -0000\r
+\r
+On Sun, 19 Feb 2012 12:25:41 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Tomi Ollila on Feb 19 at 11:43 am:\r
+> > On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems\r
+> > > like people want show refresh to retain message state by default (I\r
+> > > certainly do), rather than reset it by default.  As a nice bonus, this\r
+> > > fixes a broken test.\r
+> > \r
+> > Hmm\r
+> > \r
+> > Every '=' keypress in a thread removes 'unread' tag from next unread \r
+> > message :o\r
+> \r
+> Oh dear.  It's slightly subtler than that, though.  Refreshing will\r
+> remove the unread tag from the first message matching the query.  (I\r
+> suspect you had tag:unread in your query?)  This is particularly\r
+> confusing for state-retaining refresh because that message might not\r
+> even be open.\r
+> \r
+> > That is probably desirable feature when refreshing view without\r
+> > retaining state. Also, probably notmuch-show-refresh-view should\r
+> > be fixed not to mark next message unread when retaining state ?\r
+> \r
+> I would argue that refresh should never have side-effects, so neither\r
+> case should mark anything read.  I'll send a v2.\r
+\r
+I agree.  But this looks like a separate issue, no?  So why v2 instead\r
+of a separate patch/series?\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r