--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id B4E93431FCB\r
+ for <notmuch@notmuchmail.org>; Thu, 12 Jul 2012 13:35:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id eRvd6v59h+Ez for <notmuch@notmuchmail.org>;\r
+ Thu, 12 Jul 2012 13:35:03 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+ [18.7.68.35])\r
+ by olra.theworths.org (Postfix) with ESMTP id CF6EE431FAF\r
+ for <notmuch@notmuchmail.org>; Thu, 12 Jul 2012 13:35:02 -0700 (PDT)\r
+X-AuditID: 12074423-b7f396d0000008f4-7a-4fff34f6eea3\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id EF.F6.02292.6F43FFF4; Thu, 12 Jul 2012 16:35:02 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6CKZ1eY012353; \r
+ Thu, 12 Jul 2012 16:35:01 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6CKYxvm003237\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Thu, 12 Jul 2012 16:35:00 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1SpQ6F-0004gZ-2F; Thu, 12 Jul 2012 16:34:59 -0400\r
+Date: Thu, 12 Jul 2012 16:34:59 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH v4 2/3] Add structured output formatter for JSON.\r
+Message-ID: <20120712203459.GH7332@mit.edu>\r
+References: <87d34hsdx8.fsf@awakening.csail.mit.edu>\r
+ <1342079004-5300-1-git-send-email-craven@gmx.net>\r
+ <1342079004-5300-3-git-send-email-craven@gmx.net>\r
+ <m2vchtthm4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2vchtthm4.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hTV1v1m8t/fYMYEIYu9De2MFtdvzmS2\r
+ eLNyHqsDs8fiTfvZPA5/Xcji8WzVLeYA5igum5TUnMyy1CJ9uwSujL8zXrEVtPFV3Ft6h6WB\r
+ sZO7i5GTQ0LAROLFwbOsELaYxIV769m6GLk4hAT2MUrMmf+YCcLZwCjx/nU/M0iVkMBJJolz\r
+ L0sgEksYJT60d4ElWARUJSY9X8IGYrMJaEhs27+cEcQWEVCReNC2HmwFs4C2xJSVd5lAbGEB\r
+ V4nWp2/AbF6g+N7TW1ghFhxilJi/3B4iLihxcuYTFoheLYkb/14C1XMA2dISy/9xgJicAgYS\r
+ W67qgVSIAm2acnIb2wRGoVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrple\r
+ bmaJXmpK6SZGUKCzuyjvYPxzUOkQowAHoxIPr/DGv/5CrIllxZW5hxglOZiURHk1jP/7C/El\r
+ 5adUZiQWZ8QXleakFgN9wcGsJMKbJQGU401JrKxKLcqHSUlzsCiJ815LuekvJJCeWJKanZpa\r
+ kFoEk5Xh4FCS4JUBRrSQYFFqempFWmZOCUKaiYMTZDgP0HAOkBre4oLE3OLMdIj8KUZFKXHe\r
+ 8yAXCYAkMkrz4HphiegVozjQK8K8PCDtPMAkBtf9CmgwE9DgWT//gQwuSURISTUwqvsVRWxu\r
+ ++DuKn6Zp0ucccW092ari2aGvDnE9DD5B++dreX1a383XAq4e/IQb+aZrM5p9pP5T9+XCY43\r
+ PaUQmdE2W237pcv/PgqwlDMElkcyXzsfonk176Ihl9buaW9vc6+tYxZjNkvr+beQ4cCx1lbb\r
+ WdNNa74saPNLivcXqdgYvXf6mbtHlViKMxINtZiLihMBAAWa/B8DAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Jul 2012 20:35:04 -0000\r
+\r
+Quoth Tomi Ollila on Jul 12 at 1:10 pm:\r
+> On Thu, Jul 12 2012, craven@gmx.net wrote:\r
+> \r
+> > Using the new structured printer support in sprinter.h, implement\r
+> > sprinter_json_new, which returns a new JSON structured output\r
+> > formatter.\r
+> >\r
+> > The formatter prints output similar to the existing JSON, but with\r
+> > differences in whitespace (mostly newlines).\r
+> > ---\r
+> > Makefile.local | 1 +\r
+> > sprinter.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\r
+> > 2 files changed, 173 insertions(+)\r
+> > create mode 100644 sprinter.c\r
+> >\r
+> > diff --git a/Makefile.local b/Makefile.local\r
+> > index a890df2..8baf0c2 100644\r
+> > --- a/Makefile.local\r
+> > +++ b/Makefile.local\r
+> > @@ -290,6 +290,7 @@ notmuch_client_srcs = \\r
+> > notmuch-show.c \\r
+> > notmuch-tag.c \\r
+> > notmuch-time.c \\r
+> > + sprinter.c \\r
+> > query-string.c \\r
+> > mime-node.c \\r
+> > crypto.c \\r
+> > diff --git a/sprinter.c b/sprinter.c\r
+> > new file mode 100644\r
+> > index 0000000..649f79a\r
+> > --- /dev/null\r
+> > +++ b/sprinter.c\r
+> > @@ -0,0 +1,172 @@\r
+> > +#include <stdbool.h>\r
+> > +#include <stdio.h>\r
+> > +#include <talloc.h>\r
+> > +#include "sprinter.h"\r
+> > +\r
+> > +#define ARRAY_SIZE(arr) (sizeof (arr) / sizeof (arr[0]))\r
+> \r
+> You're including sprinter.h which includes notmuch-client.h which\r
+> defines ARRAY_SIZE (Interesting that you did not get error(/warning?)\r
+> about this)\r
+> \r
+> Rest looks good -- except the whitespace -- as I looked through Austin's\r
+> code yesterday you're just replicated the same lines :D. Easiest\r
+> to fix is probably just running \r
+> uncrustify -c devel/uncrustify.cfg --replace sprinter.c \r
+\r
+Oops. Shame on me. Is anything wrong besides the missing space\r
+before the argument list of all of the function declarations?\r
projects / notmuch-archives.git / commitdiff