Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

diff --git a/34/16a2ed3286fbfd13c205e8975cc36d28a50493 b/34/16a2ed3286fbfd13c205e8975cc36d28a50493
new file mode 100644 (file)
index 0000000..af6e53d
--- /dev/null
+++ b/34/16a2ed3286fbfd13c205e8975cc36d28a50493
@@ -0,0 +1,109 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5B7CF431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 23:47:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qHO5ktjqSUxz for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Feb 2012 23:47:48 -0800 (PST)\r
+Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com\r
+ [74.125.82.45])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 54A16431FAE   for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 23:47:48 -0800\r
+ (PST)\r
+Received: by wgbdt12 with SMTP id dt12so5164430wgb.2\r
+       for <notmuch@notmuchmail.org>; Sun, 05 Feb 2012 23:47:45 -0800 (PST)\r
+Received: by 10.180.93.132 with SMTP id cu4mr11237232wib.9.1328514465744;\r
+       Sun, 05 Feb 2012 23:47:45 -0800 (PST)\r
+Received: from hotblack-desiato.hh.sledj.net\r
+       (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])\r
+       by mx.google.com with ESMTPS id j16sm43906178wie.4.2012.02.05.23.47.43\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 05 Feb 2012 23:47:44 -0800 (PST)\r
+Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)\r
+       id A3D47A0484; Mon,  6 Feb 2012 07:47:41 +0000 (GMT)\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.\r
+In-Reply-To: <87sjiobfu1.fsf@servo.finestructure.net>\r
+References: <1327496913-4946-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-3-git-send-email-dme@dme.org>\r
+       <87sjiobfu1.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11.1+152~g2c6710e (http://notmuchmail.org)\r
+       Emacs/24.0.92.1 (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 06 Feb 2012 07:47:38 +0000\r
+Message-ID: <cunvcnk4d45.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Gm-Message-State:\r
+ ALoCoQnHMw1Y7jwVgH2JwT8qzJgxN80a/f61AgbBZXLfkK08uMzVQAzuwCdcVE0D5r8m2ca6cNR4\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Feb 2012 07:47:49 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+> Sorry to be so late on this, but I'm not a big fan of this new feature.\r
+> I would prefer to always see the subject (or any other field for that\r
+> matter) as is.\r
+\r
+The Emacs UI always replaced blank subjects with '[No Subject]' in\r
+buffer names. The printing code also needed something other than a blank\r
+subject for buffer renaming.\r
+\r
+> As a principle I would prefer there not be text replacements unless it's\r
+> very clear that text has been replaced.  Buttons work because it's clear\r
+> they're buttons.  This is not the case here, though, since this text\r
+> replacement could actually be confused with real text.\r
+>=20\r
+> It's also not clear to me why this feature would be needed.  I have\r
+> never found blank subjects confusing.  The field is always clearly\r
+> delineated, at least in search and show mode.  If it's not clear\r
+> elsewhere, maybe we can make the delineation of the subject field\r
+> clearer, but leave the actual subject text string alone.\r
+>=20\r
+> If some feel this feature is really needed we should at least have a\r
+> customization variable.  notmuch-unblank-subject?  I don't have any good\r
+> name suggestions, though.\r
+\r
+Updating `notmuch-prettify-subject' to use a user configurable string\r
+(that can be set to the empty string) sounds like a good idea. Please\r
+ensure that the various other bits of code that require something other\r
+than a blank subject still work properly.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEUEARECAAYFAk8vhZoACgkQaezQq/BJZRarMgCYrFque60z5T2myWwEd/Emj1Yh\r
+5QCePKwlzHTZyk9mQ5KiwmdmDvxbprk=\r
+=mPKI\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r