--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 44292431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 13 Mar 2012 19:47:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id WLcnNozfva6h for <notmuch@notmuchmail.org>;\r
+ Tue, 13 Mar 2012 19:47:17 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+ [18.9.25.14])\r
+ by olra.theworths.org (Postfix) with ESMTP id C24F7431FAE\r
+ for <notmuch@notmuchmail.org>; Tue, 13 Mar 2012 19:47:17 -0700 (PDT)\r
+X-AuditID: 1209190e-b7f7c6d0000008c3-47-4f6006b5703a\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+ by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 46.03.02243.5B6006F4; Tue, 13 Mar 2012 22:47:17 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q2E2lHmi020042; \r
+ Tue, 13 Mar 2012 22:47:17 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2E2lGle026400\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Tue, 13 Mar 2012 22:47:16 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1S7eFA-0005wS-1o; Tue, 13 Mar 2012 22:47:16 -0400\r
+Date: Tue, 13 Mar 2012 22:47:16 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH v2 0/2] cli: Allow true/false parameter for boolean\r
+Message-ID: <20120314024716.GL2787@mit.edu>\r
+References: <1331377533-30262-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1331377533-30262-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hTV1t3KluBv8Pa9jMXquTwW12/OZHZg\r
+ 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4MiY17mMv+MlTcWH2V/YGxh+cXYycHBICJhL3\r
+ d/1lh7DFJC7cW8/WxcjFISSwj1Fi1vbLYAkhgQ2MEtcOC0PYJ5kk1i8phShawiixYvVkFpAE\r
+ i4CqxKV175hBbDYBDYlt+5czgtgiAjoStw8tABvELCAt8e13MxOILSzgLvFu0lywGl4BbYnz\r
+ c5YxQyzwlDjztIcFIi4ocXLmExaIXi2JG/9eAvVygM1Z/o8DJMwp4CUx9dEFsBJRARWJKSe3\r
+ sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrr5WaW6KWmlG5iBIe0\r
+ JN8Oxq8HlQ4xCnAwKvHwCtfG+wuxJpYVV+YeYpTkYFIS5Y18CxTiS8pPqcxILM6ILyrNSS0+\r
+ xCjBwawkwvtiKlCONyWxsiq1KB8mJc3BoiTOq6b1zk9IID2xJDU7NbUgtQgmK8PBoSTBqwIy\r
+ VLAoNT21Ii0zpwQhzcTBCTKcB2h4+XeQ4cUFibnFmekQ+VOMilLivHfeACUEQBIZpXlwvbCU\r
+ 84pRHOgVYd6VIFU8wHQF1/0KaDAT0OCSb3Egg0sSEVJSDYzlHz68ylLVs53/e9MZa5NEw2/R\r
+ 7DO06krLJWyZPH2Y6zSXKq05vjy7PU90wuae3V7m9+6tmXpDh3V7+CnNa0q8/+e+WbrvkYDJ\r
+ ze9R1QIb723W5JX1bquofStx9XLRwk83tzAnzbgy44rV9/yYj60XXkbc4H94TUf+i/3WXE2+\r
+ m89fn/68JmC3EktxRqKhFnNRcSIANjYZ+xQDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Mar 2012 02:47:18 -0000\r
+\r
+Quoth Mark Walters on Mar 10 at 11:05 am:\r
+> Hi\r
+> \r
+> Here is a second version of a patch to allow parameters to boolean\r
+> options on the command line. This version allows parameters\r
+> (=true|false). My first version is at\r
+> id:"1331244944-7960-1-git-send-email-markwalters1009@gmail.com". Jani\r
+> posted an alternative version there. Jani's version and this one are\r
+> quite similar: the key difference is that this version abuses a\r
+> notmuch_bool_t by setting it to -1 (to indicate that the parser has\r
+> not set this option). This makes the code simpler but is definitely an\r
+> abuse. I will discuss this further in replies to Jani's series.\r
+> \r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> Mark Walters (2):\r
+> cli: Parsing. Allow true/false parameter for boolean options.\r
+> cli: make --entire-thread=false work for format=json.\r
+\r
+LGTM. The one question I have is whether or not the resulting\r
+non-entire-thread behavior of the JSON format is actually what we\r
+*want*. As a probably unintentional consequence of the current show\r
+code, we get\r
+\r
+# A message and its replies (show_messages)\r
+thread_node = [\r
+ message?, # present if --entire-thread or matched\r
+ [thread_node*] # children of message\r
+]\r
+\r
+But would it be better to have\r
+\r
+thread_node = [\r
+ message|null, # non-null if --entire-thread or matched\r
+ [thread_node*] # children of message\r
+]\r
+\r
+? The latter is much more natural for consumers to work with\r
+(checking whether the message matched or not is more natural and the\r
+index of the child list doesn't change), but would require a little\r
+more code in show to support.\r
projects / notmuch-archives.git / commitdiff