Re: Xapian-quoting based batch-tagging.
authorJani Nikula <jani@nikula.org>
Thu, 3 Jan 2013 19:59:36 +0000 (20:59 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:52:55 +0000 (09:52 -0800)
dc/fdf2e629e383dd8797dd8d6a118f6297db31b0 [new file with mode: 0644]

diff --git a/dc/fdf2e629e383dd8797dd8d6a118f6297db31b0 b/dc/fdf2e629e383dd8797dd8d6a118f6297db31b0
new file mode 100644 (file)
index 0000000..21bfeae
--- /dev/null
@@ -0,0 +1,119 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75A15431FBC\r
+       for <notmuch@notmuchmail.org>; Thu,  3 Jan 2013 11:59:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 020aWyfb0CKt for <notmuch@notmuchmail.org>;\r
+       Thu,  3 Jan 2013 11:59:45 -0800 (PST)\r
+Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com\r
+ [74.125.82.52])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 57065431FAF   for <notmuch@notmuchmail.org>; Thu,  3 Jan 2013 11:59:45 -0800\r
+ (PST)\r
+Received: by mail-wg0-f52.google.com with SMTP id 12so7385423wgh.7\r
+       for <notmuch@notmuchmail.org>; Thu, 03 Jan 2013 11:59:44 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=x-received:from:to:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=XBS8Vx9BgJZgPwnZKEQ9l92RV5Ye9VFIi2BxaRkHceg=;\r
+       b=hUIOtdJkQDM8PctNz0kY59kcWdyrXvkZg2j0kWiEUY5qK+64MoNUSsqKH9yRnL8PhL\r
+       1Rn7uwvBOEe8wXNt+S2heOn7KiHRke0KpBc3YyoI1mMt+GlhkQ+85EcvwFNYQY6nhJiv\r
+       3koAip/WEpfaJnAFiFX/CRLw8bmk5gYijLWGgfhHsYP2feebSQJ3QSVk+13Zkr9FoBFF\r
+       pcHtmRfWxmLIPqnBJw+Idvg0I1x5/DtETwyIKG3TMKKXyClJsLxNXcY9RgMiKj1/uSJB\r
+       j+xzAVr2NvT5s/ScjLlz7hJis2/1AkyLdJ9mFYBJkV3qwkDtbagR39dhFl0dAw2Ham+T\r
+       mw2w==\r
+X-Received: by 10.194.90.238 with SMTP id bz14mr71511147wjb.9.1357243184273;\r
+       Thu, 03 Jan 2013 11:59:44 -0800 (PST)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPS id ex6sm86919064wid.3.2013.01.03.11.59.42\r
+       (version=SSLv3 cipher=OTHER); Thu, 03 Jan 2013 11:59:43 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: Xapian-quoting based batch-tagging.\r
+In-Reply-To: <1356464567-21779-1-git-send-email-david@tethera.net>\r
+References: <1356464567-21779-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+235~gdaf492b (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 03 Jan 2013 20:59:36 +0100\r
+Message-ID: <87ip7eghqv.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQm57XiI/f3azGcldwyB9o6HcKDUndm7ki9pI/Bup88httpyRjiNvMURM4lnGKEvNkIHcuR5\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 03 Jan 2013 19:59:49 -0000\r
+\r
+On Tue, 25 Dec 2012, david@tethera.net wrote:\r
+> This is an alternative version of \r
+>\r
+>      id:1356313183-9266-1-git-send-email-david@tethera.net\r
+>\r
+> batch tagging patches rebased on top of \r
+>\r
+>      id:1356415076-5692-1-git-send-email-amdragon@mit.edu\r
+\r
+I didn't go through this quite as thoroughly as the previous versions,\r
+but the series LGTM. I like how this simplifies things. In the future,\r
+I'd like us to support xapian quoting also in the tag changes, for\r
+consistency.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+\r
+>\r
+> This mainly consisted of removing \r
+>\r
+>      [Patch v9 04/17] notmuch-tag: factor out double quoting routine\r
+>      (superceded by one of Austin's patches)\r
+>\r
+>      [Patch v9 05/17] util/string-util: add a new string tokenized function\r
+>      [Patch v9 06/17] unhex_and_quote: new function to quote hex-decoded queries\r
+>      [Patch v9 07/17] notmuch-restore: move query handling for batch \r
+>      (uneeded if query is passed verbatim to xapian)\r
+>\r
+>      I also removed two tests, since they are about how we handle\r
+>      quoting:\r
+>\r
+>      [Patch v9 13/17] test/tagging: add test for compound queries with batch tagging\r
+>      [Patch v9 17/17] test/tagging: add test for handling of parenthesized   tag queries.\r
+>\r
+> A few small fixes were needed to the tests, and a fair amount of\r
+> changes to the notmuch-tag man page.\r
+>\r
+> Diffstat (against Austin's series) is as follows\r
+>\r
+>  man/man1/notmuch-tag.1 |   99 ++++++++++++++++++++-\r
+>  notmuch-tag.c          |  169 ++++++++++++++++++++----------------\r
+>  tag-util.c             |   87 +++++++++++++++++--\r
+>  tag-util.h             |   15 ++++\r
+>  test/tagging           |  195 ++++++++++++++++++++++++++++++++++++++++++\r
+>  5 files changed, 480 insertions(+), 85 deletions(-)\r
+>\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r