--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 20952431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 01:38:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id z5muYdBIl45a for <notmuch@notmuchmail.org>;\r
+ Sun, 12 Feb 2012 01:38:15 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 49C84431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 01:38:15 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1RwVsr-0001SA-KC; Sun, 12 Feb 2012 09:38:13 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1RwVsr-0006L5-9V; Sun, 12 Feb 2012 09:38:13 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 3/3] emacs: Don't insert a part header if it's the\r
+ first part and text/*.\r
+In-Reply-To: <87r4y0ieva.fsf@qmul.ac.uk>\r
+References: <1327052612-1040-1-git-send-email-dme@dme.org>\r
+ <1328542748-19530-1-git-send-email-dme@dme.org>\r
+ <1328542748-19530-5-git-send-email-dme@dme.org>\r
+ <87r4y0ieva.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.11.1+172~g6a5d2c5 (http://notmuchmail.org) Emacs/23.2.1\r
+ (i486-pc-linux-gnu)\r
+Date: Sun, 12 Feb 2012 09:39:32 +0000\r
+Message-ID: <87fweg1jcb.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 95fa201e58d8ffc27aa9d83b184efb89 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 12 Feb 2012 09:38:16 -0000\r
+\r
+\r
+On Sun, 12 Feb 2012 09:24:09 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> On Mon, 6 Feb 2012 15:39:08 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > Previously this logic applied only to text/plain. Allow it for other\r
+> > text/* parts as well.\r
+> \r
+> What is the reason for treating the first part differently? \r
+> \r
+> Personally, I would prefer to keep it as now since pressing v on the\r
+> [text/html] `views' the message in my mailcap preferred html viewer\r
+> which can be convenient.\r
+\r
+Actually I experimented with this and if I remove the special case\r
+totally (i.e., for text/plain as well) I get a button which lets me save\r
+the text part of the email fixing the problem I mentioned in\r
+id:"87y5tl3xz0.fsf@qmul.ac.uk"\r
+\r
+I wonder if it would be possible to always include the button but\r
+possibly at the end rather than the start of the message? Or possibly\r
+add a view-mime-part-structure function which showed all the buttons.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> \r
+> Thanks\r
+> \r
+> Mark\r
+> \r
+> \r
+> > ---\r
+> > emacs/notmuch-show.el | 9 ++++-----\r
+> > 1 files changed, 4 insertions(+), 5 deletions(-)\r
+> > \r
+> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> > index ce79762..c60e613 100644\r
+> > --- a/emacs/notmuch-show.el\r
+> > +++ b/emacs/notmuch-show.el\r
+> > @@ -412,7 +412,9 @@ CONTENT-TYPE parts."\r
+> > (defun notmuch-show-insert-part-header (nth content-type declared-type\r
+> > &optional name comment\r
+> > &rest button-parameters)\r
+> > - (unless (notmuch-show-hidden-part-header content-type)\r
+> > + (unless (or (notmuch-show-hidden-part-header content-type)\r
+> > + (and (= nth 1)\r
+> > + (string-match "text/*" content-type)))\r
+> > (apply #'insert-button\r
+> > (concat "[ "\r
+> > (if name (concat name ": ") "")\r
+> > @@ -703,10 +705,7 @@ current buffer, if possible."\r
+> > \r
+> > (defun notmuch-show-insert-part-text/plain (msg part content-type nth depth declared-type)\r
+> > (let ((start (point)))\r
+> > - ;; If this text/plain part is not the first part in the message,\r
+> > - ;; insert a header to make this clear.\r
+> > - (if (> nth 1)\r
+> > - (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename)))\r
+> > + (notmuch-show-insert-part-header nth declared-type content-type (plist-get part :filename))\r
+> > (insert (notmuch-show-get-bodypart-content msg part nth))\r
+> > (save-excursion\r
+> > (save-restriction\r
+> > -- \r
+> > 1.7.8.3\r
+> > \r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff