Re: [Patch v2 0/3] Add test and fix exclude bug

diff --git a/0d/48ea7cb25c2a0e3fa6aaf4bb05a357038a9741 b/0d/48ea7cb25c2a0e3fa6aaf4bb05a357038a9741
new file mode 100644 (file)
index 0000000..5384d4c
--- /dev/null
+++ b/0d/48ea7cb25c2a0e3fa6aaf4bb05a357038a9741
@@ -0,0 +1,98 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 50926431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Mar 2012 20:34:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5Ssw3vKYHlUj for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Mar 2012 20:33:59 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id CCA8B431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Mar 2012 20:33:59 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f8a6d000000914-f4-4f62b4a53406\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 52.98.02324.5A4B26F4; Thu, 15 Mar 2012 23:33:57 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q2G3XvRJ006500; \r
+       Thu, 15 Mar 2012 23:33:57 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2G3XumX029383\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 15 Mar 2012 23:33:56 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1S8NvQ-0002FS-1x; Thu, 15 Mar 2012 23:33:56 -0400\r
+Date: Thu, 15 Mar 2012 23:33:56 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [Patch v2 0/3] Add test and fix exclude bug\r
+Message-ID: <20120316033356.GE2670@mit.edu>\r
+References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFupnleLIzCtJLcpLzFFi42IRYrdT0V26Jcnf4PZSE4vVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZXTsmMFScIGjomXTH/YGxh9sXYycHBICJhLn\r
+       n95mh7DFJC7cWw8U5+IQEtjHKPFl+20oZwOjxJQZE5khnJNMEiuv3oXKLGGU2D21iwmkn0VA\r
+       VeLurw5GEJtNQENi2/7lYLaIgI7E7UMLwHYwC0hLfPvdDFYvLGAhsfP3QbAaXgFtiSUtJ5hB\r
+       bCEBT4k/D6axQsQFJU7OfMIC0aslcePfS6BeDrA5y/9xgIQ5BbwkHjSuAysXFVCRmHJyG9sE\r
+       RqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6JXm5miV5qSukmRlBYc0ry\r
+       72D8dlDpEKMAB6MSD+9K/iR/IdbEsuLK3EOMkhxMSqK8RsuAQnxJ+SmVGYnFGfFFpTmpxYcY\r
+       JTiYlUR4MwwS/YV4UxIrq1KL8mFS0hwsSuK8alrv/IQE0hNLUrNTUwtSi2CyMhwcShK8YsD4\r
+       FRIsSk1PrUjLzClBSDNxcIIM5wEa/mozUA1vcUFibnFmOkT+FKMuR/fUR5cYhVjy8vNSpcR5\r
+       34AUCYAUZZTmwc2BpaNXjOJAbwnz/gKp4gGmMrhJr4CWMAEtKfkWB7KkJBEhJdXAGLRKrHS/\r
+       82YtVa7UfOU1H7xcH74U+LslT9Tq4DVtE2/OvYei3sYbpe/5ZHf5+0PPnUI7C7hZ+pfc5In4\r
+       bxq3J2WJvpVAtfTL9EuC3d9Pr2j36dhZMKF8NYPbulWnpA9U5xWt/bPxATfT3rlvPXKmlO2t\r
+       e23xZerBA9MPJe2s7v+zcmr43QSfK0osxRmJhlrMRcWJADUmDqwiAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 16 Mar 2012 03:34:00 -0000\r
+\r
+Quoth Mark Walters on Mar 14 at 12:26 pm:\r
+> The test in the previous patches\r
+> id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com"\r
+> triggered the bug accidentally. It accidentally set the exclude tags\r
+> to be "=" and "deleted" rather than just "deleted". The non-existent\r
+> "=" tag (i.e., the tag that does not occur anywhere in the Xapian\r
+> database) triggered the bug. First we correct the tests to just set\r
+> the "deleted" tag, then we add some tests including one with a\r
+> deliberately non-existent tag. Finally, we modify the exclusion code\r
+> to avoid the bug.\r
+> \r
+> The modification also appears to fix a similar problem for jrollins\r
+> that I have not yet been able to reproduce.\r
+> \r
+> Since the code is now more clearly correct, cleaner and we do\r
+> definitely avoid a Xapian bug I think these patches can be committed\r
+> even without knowing why it fixed jrollins' bug.\r
+> \r
+> Finally these apply to current master (not to the --with-excluded series).\r
+\r
+LGTM.  It would be nice to have the broken tests marked broken in the\r
+patch that introduces them, but it's fine.\r