Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane

diff --git a/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4 b/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4
new file mode 100644 (file)
index 0000000..464b9bd
--- /dev/null
+++ b/69/fd2b6478e318c586a17d76c6b475ba9ba0e2b4
@@ -0,0 +1,105 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id AF1D4431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 13:50:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mH2M9GAb+7kz for <notmuch@notmuchmail.org>;\r
+       Sun, 12 Feb 2012 13:50:02 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D8CDE429E52\r
+       for <notmuch@notmuchmail.org>; Sun, 12 Feb 2012 13:50:01 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RwhJ2-0006wo-9M; Sun, 12 Feb 2012 21:50:00 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RwhJ2-0003EA-0n; Sun, 12 Feb 2012 21:50:00 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view\r
+       with split-pane\r
+In-Reply-To: <878vk73hxq.fsf@servo.finestructure.net>\r
+References: <1329072579-27340-1-git-send-email-markwalters1009@gmail.com>\r
+       <878vk73hxq.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11.1+192~g23e894e (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Sun, 12 Feb 2012 21:51:20 +0000\r
+Message-ID: <87zkcnra93.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 40fbea20fc0f6804767c4a549cc463f6 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 12 Feb 2012 21:50:02 -0000\r
+\r
+On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> > Here is a rebased version of the notmuch-pick patch set\r
+> > id:"87d39k1gvi.fsf@qmul.ac.uk". It now applies directly \r
+> > to master since Jani's notmuch-show command line parsing \r
+> > has been pushed.\r
+> \r
+> Hey, Mark.  Thanks for working on this.  However, none of the patches\r
+> have commit messages, so there's no explanation for what any of the\r
+> patches are supposed to do.  This is particularly bothersome for the\r
+> first patch, which introduces a lot of unexplained changes to the cli.\r
+> \r
+> I think I would like to review this patch set, since I think I'm\r
+> interested in the functionality it may be introducing, but without any\r
+> commit messages or explanation what the patches are meant to do it's\r
+> kind of a non starter for me.\r
+\r
+Hi \r
+\r
+At the moment I was mostly looking for feedback on whether people like\r
+the final outcome (i.e., whether people liked it enough to be worth\r
+tidying). I will add comments on the first two patches.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r