Re: [PATCH 00/10] Solaris support

diff --git a/40/da5c20f00273e79a9b062121818a142a3413be b/40/da5c20f00273e79a9b062121818a142a3413be
new file mode 100644 (file)
index 0000000..ef5e6e1
--- /dev/null
+++ b/40/da5c20f00273e79a9b062121818a142a3413be
@@ -0,0 +1,78 @@
+Return-Path: <blakej@foo.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3A231431FC0\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 10:36:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id f8-G5VSUuj9Q for <notmuch@notmuchmail.org>;\r
+       Mon,  5 Nov 2012 10:36:13 -0800 (PST)\r
+Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BB3A3431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 10:36:13 -0800 (PST)\r
+Received: from foo.net (localhost [127.0.0.1])\r
+       by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA5Ia8SG010910;\r
+       Mon, 5 Nov 2012 10:36:08 -0800 (PST)\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 00/10] Solaris support \r
+In-Reply-To: Your message of "Mon, 05 Nov 2012 19:43:08 +0200."\r
+       <m2fw4oeyj7.fsf@guru.guru-group.fi> \r
+Date: Mon, 05 Nov 2012 10:36:08 -0800\r
+Message-ID: <10909.1352140568@foo.net>\r
+From: Blake Jones <blakej@foo.net>\r
+X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2\r
+       (foo.net [127.0.0.1]); Mon, 05 Nov 2012 10:36:08 -0800 (PST)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 05 Nov 2012 18:36:14 -0000\r
+\r
+> Just now I don't have more time to comment and review more, but in the\r
+> first 2/3 patches when I tried to compile I got problem NULL not\r
+> defined.\r
+\r
+Oh!  Yes, I should include <stdio.h> to pull in the definition of NULL.\r
+I'll fix that.\r
+\r
+> Another thing: you have this\r
+> \r
+>  +# Whether the asctime_r function is standards-compliant\r
+>  +# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS\r
+>  +# to enable the standards-compliant version -- needed for Solaris)\r
+> \r
+> which is not exactly so.. you added the following lines in compat.h\r
+> \r
+>  +#if !STD_GETPWUID\r
+>  +#define _POSIX_PTHREAD_SEMANTICS\r
+>  +#endif\r
+> \r
+> which is slightly different as -D_POSIX_PTHREAD_SEMANTICS is equivalent to \r
+> #define _POSIX_PTHREAD_SEMANTICS 1\r
+> \r
+> (you probably knew this and your comments have drifted from actual\r
+> implementation but just to make sure)\r
+\r
+I'll make the code and comment line up better.\r
+\r
+Thanks for your comments.\r
+\r
+Blake\r