--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 72581431FBD\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 01:42:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Cefhl3FB3QRg for <notmuch@notmuchmail.org>;\r
+ Wed, 4 Jul 2012 01:42:02 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id AB3FD431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 01:42:01 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SmL9s-0007XZ-1i; Wed, 04 Jul 2012 09:42:00 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SmL9r-0003I1-PH; Wed, 04 Jul 2012 09:41:59 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/8] emacs: Helper for reporting search parsing errors\r
+In-Reply-To: <1341354059-29396-5-git-send-email-amdragon@mit.edu>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+ <1341354059-29396-5-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+70~gb6a56e7 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 04 Jul 2012 09:41:56 +0100\r
+Message-ID: <87ehorhq97.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 63fbf2399b833a59425a4ac623a80674 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jul 2012 08:42:02 -0000\r
+\r
+On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> This removes the last bit of direct output from the parsing function.\r
+> With the parser now responsible solely for parsing, we can swap it out\r
+> for another parser.\r
+> ---\r
+> emacs/notmuch.el | 10 +++++++++-\r
+> 1 file changed, 9 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 4a6490a..a073367 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -745,6 +745,13 @@ non-authors is found, assume that all of the authors match."\r
+> (setq notmuch-search-target-thread "found")\r
+> (goto-char beg)))))\r
+> \r
+> +(defun notmuch-search-show-error (string &rest objects)\r
+> + (save-excursion\r
+> + (goto-char (point-max))\r
+> + (insert "Error: Unexpected output from notmuch search:\n")\r
+> + (insert (apply #'format string objects))\r
+> + (insert "\n")))\r
+> +\r
+> (defun notmuch-search-process-filter (proc string)\r
+> "Process and filter the output of \"notmuch search\""\r
+> (let ((buffer (process-buffer proc)))\r
+> @@ -767,7 +774,8 @@ non-authors is found, assume that all of the authors match."\r
+> (tags (match-string 6 string))\r
+> (tag-list (if tags (save-match-data (split-string tags)))))\r
+> (if (/= (match-beginning 1) line)\r
+> - (insert (concat "Error: Unexpected output from notmuch search:\n" (substring string line (match-beginning 1)) "\n")))\r
+> + (notmuch-search-show-error\r
+> + (substring string line (match-beginning 1))))\r
+> (notmuch-search-show-result thread-id date count authors subject tag-list)\r
+> (set 'line (match-end 0)))\r
+> (set 'more nil)\r
+\r
+Ok so I should have read this patch before replying to the previous\r
+one. This fixes my one trivial concern with Patch 3 and looks good in\r
+itself.\r
+\r
+I have read Patches 1-4 and they all look fine and make things cleaner\r
+and all tests pass. As Austin says, they stand on their own and can go\r
+in without the rest of the series.\r
+\r
+On to patches 5-8!\r
+\r
+Best wishes\r
+\r
+Mark\r
projects / notmuch-archives.git / commitdiff