Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

diff --git a/4f/9cfe13ac64dbbef9045d2e0909a9b36982e534 b/4f/9cfe13ac64dbbef9045d2e0909a9b36982e534
new file mode 100644 (file)
index 0000000..a011e12
--- /dev/null
+++ b/4f/9cfe13ac64dbbef9045d2e0909a9b36982e534
@@ -0,0 +1,88 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E12A3431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Nov 2012 16:17:17 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 97jdFiVXUFVu for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Nov 2012 16:17:17 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7C41A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Nov 2012 16:17:17 -0800 (PST)\r
+Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.167.90.129] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TeEI7-0002bL-U4; Thu, 29 Nov 2012 20:17:16 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1TeEI2-0006RW-Co; Thu, 29 Nov 2012 20:17:10 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging\r
+       routines\r
+In-Reply-To: <87vcctiauq.fsf@qmul.ac.uk>\r
+References: <1353792017-31459-1-git-send-email-david@tethera.net>\r
+       <1353792017-31459-10-git-send-email-david@tethera.net>\r
+       <87vcctiauq.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 29 Nov 2012 20:17:10 -0400\r
+Message-ID: <87pq2wgd15.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 30 Nov 2012 00:17:18 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+\r
+> I don't know how freeze/thaw work but does it matter that you don't thaw\r
+> when there is an error?\r
+\r
+My interpretation is that by not thawing before we destroy the message,\r
+we are aborting the transaction, since the freeze/thaw information is\r
+stored in the message structure. It is documented as forbidden to call\r
+thaw _more_ times than freeze, but less is not explicitely mentioned.\r
+\r
+>> +\r
+>> +/*\r
+>> + * Add a tag operation (delete iff remote == TRUE) to a list.\r
+>> + * The list is expanded as necessary.\r
+>> + */\r
+>\r
+> Typo s/remote/remove/\r
+\r
+fixed in local git.\r
+>> +\r
+>> +/*\r
+>> + * Apply a list of tag operations, in order to a message.\r
+>\r
+> I found the comment awkward to parse: as "in order to <do something>"\r
+\r
+Re-punctu-worded to \r
+\r
+"Apply a list of tag operations, in order, to a given message"\r