--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 6BDD2431FB6\r
+ for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 10:45:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id rn2IHlW+dRcC for <notmuch@notmuchmail.org>;\r
+ Tue, 17 Apr 2012 10:45:19 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1B6EF431FAE\r
+ for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 10:45:19 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SKCSj-00005I-Mm; Tue, 17 Apr 2012 18:45:14 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SKCSj-0005dZ-4m; Tue, 17 Apr 2012 18:45:09 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Edmondson <dme@dme.org>\r
+Subject: Re: [PATCH 2/3] test: emacs: toggle eliding of non-matching messages\r
+ in `notmuch-show'\r
+In-Reply-To: <1329684990-12504-3-git-send-email-pieter@praet.org>\r
+References: <1328688139-3865-1-git-send-email-dme@dme.org>\r
+ <1329684990-12504-1-git-send-email-pieter@praet.org>\r
+ <1329684990-12504-3-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.12+110~gbc97b4a (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 17 Apr 2012 18:45:29 +0100\r
+Message-ID: <87k41e45hi.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: c3b1035556ae15a6b6889a6fcf194c1a (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.2\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.2 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 1.0 FREEMAIL_REPLY From and body contain different freemails\r
+ * 0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Apr 2012 17:45:24 -0000\r
+\r
+On Sun, 19 Feb 2012, Pieter Praet <pieter@praet.org> wrote:\r
+> See commits 44a544ed, 866ce8b1, 668b66ec.\r
+> ---\r
+> test/emacs | 38 ++++++++++\r
+> .../notmuch-show-elide-non-matching-messages-off | 79 ++++++++++++++++++++\r
+> .../notmuch-show-elide-non-matching-messages-on | 75 +++++++++++++++++++\r
+> 3 files changed, 192 insertions(+), 0 deletions(-)\r
+> create mode 100644 test/emacs.expected-output/notmuch-show-elide-non-matching-messages-off\r
+> create mode 100644 test/emacs.expected-output/notmuch-show-elide-non-matching-messages-on\r
+\r
+This patch looks good to me and with other possible ways of implementing\r
+elide [1] seems well worth having.\r
+\r
+It needs [1/3] which I think is ok but I have never used the crypto\r
+stuff so wouldn't count this as a review of that patch.\r
+\r
+Patch [3/3] also looks fine.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+[1] id:"1334077496-9172-1-git-send-email-markwalters1009@gmail.com"\r
+>\r
+> diff --git a/test/emacs b/test/emacs\r
+> index b207d20..320057a 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -553,5 +553,43 @@ test_emacs '(let ((notmuch-crypto-process-mime nil))\r
+> (test-visible-output))'\r
+> test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-process-crypto-mime-parts-on\r
+> \r
+> +test_begin_subtest "notmuch-show: don't elide non-matching messages"\r
+> +test_emacs '(let ((notmuch-show-only-matching-messages nil))\r
+> + (notmuch-search "from:lars@seas.harvard.edu and subject:\"Maildir storage\"")\r
+> + (notmuch-test-wait)\r
+> + (notmuch-search-show-thread)\r
+> + (notmuch-test-wait)\r
+> + (test-visible-output))'\r
+> +test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-elide-non-matching-messages-off\r
+> +\r
+> +test_begin_subtest "notmuch-show: elide non-matching messages"\r
+> +test_emacs '(let ((notmuch-show-only-matching-messages t))\r
+> + (notmuch-search "from:lars@seas.harvard.edu and subject:\"Maildir storage\"")\r
+> + (notmuch-test-wait)\r
+> + (notmuch-search-show-thread)\r
+> + (notmuch-test-wait)\r
+> + (test-visible-output))'\r
+> +test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-elide-non-matching-messages-on\r
+> +\r
+> +test_begin_subtest "notmuch-show: elide non-matching messages (w/ notmuch-show-toggle-elide-non-matching)"\r
+> +test_emacs '(let ((notmuch-show-only-matching-messages nil))\r
+> + (notmuch-search "from:lars@seas.harvard.edu and subject:\"Maildir storage\"")\r
+> + (notmuch-test-wait)\r
+> + (notmuch-search-show-thread)\r
+> + (notmuch-test-wait)\r
+> + (notmuch-show-toggle-elide-non-matching)\r
+> + (test-visible-output))'\r
+> +test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-elide-non-matching-messages-on\r
+> +\r
+> +test_begin_subtest "notmuch-show: elide non-matching messages (w/ prefix arg to notmuch-show)"\r
+> +test_emacs '(let ((notmuch-show-only-matching-messages nil))\r
+> + (notmuch-search "from:lars@seas.harvard.edu and subject:\"Maildir storage\"")\r
+> + (notmuch-test-wait)\r
+> + (let ((current-prefix-arg t))\r
+> + (notmuch-search-show-thread))\r
+> + (notmuch-test-wait)\r
+> + (test-visible-output))'\r
+> +test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-elide-non-matching-messages-on\r
+> +\r
+> \r
+> test_done\r
+> diff --git a/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-off b/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-off\r
+> new file mode 100644\r
+> index 0000000..b31fe62\r
+> --- /dev/null\r
+> +++ b/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-off\r
+> @@ -0,0 +1,79 @@\r
+> +Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)\r
+> +Subject: [notmuch] Working with Maildir storage?\r
+> +To: notmuch@notmuchmail.org\r
+> +Date: Tue, 17 Nov 2009 14:00:54 -0500\r
+> +\r
+> +[ multipart/mixed ]\r
+> +[ multipart/signed ]\r
+> +[ text/plain ]\r
+> +I saw the LWN article and decided to take a look at notmuch. I'm\r
+> +currently using mutt and mairix to index and read a collection of\r
+> +Maildir mail folders (around 40,000 messages total).\r
+> +\r
+> +notmuch indexed the messages without complaint, but my attempt at\r
+> +searching bombed out. Running, for example:\r
+> +\r
+> + notmuch search storage\r
+> +\r
+> +Resulted in 4604 lines of errors along the lines of:\r
+> +\r
+> + Error opening\r
+> + /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:\r
+> + Too many open files\r
+> +\r
+> +I'm curious if this is expected behavior (i.e., notmuch does not work\r
+> +with Maildir) or if something else is going on.\r
+> +\r
+> +Cheers,\r
+> +\r
+> +[ 4-line signature. Click/Enter to show. ]\r
+> +[ application/pgp-signature ]\r
+> +[ text/plain ]\r
+> +[ 4-line signature. Click/Enter to show. ]\r
+> + Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)\r
+> + Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)\r
+> + Subject: Re: [notmuch] Working with Maildir storage?\r
+> + To: Mikhail Gusarov <dottedmag@dottedmag.net>\r
+> + Cc: notmuch@notmuchmail.org\r
+> + Date: Tue, 17 Nov 2009 15:33:01 -0500\r
+> +\r
+> + [ multipart/mixed ]\r
+> + [ multipart/signed ]\r
+> + [ text/plain ]\r
+> + > See the patch just posted here.\r
+> +\r
+> + Is the list archived anywhere? The obvious archives\r
+> + (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I\r
+> + think I subscribed too late to get the patch (I only just saw the\r
+> + discussion about it).\r
+> +\r
+> + It doesn't look like the patch is in git yet.\r
+> +\r
+> + -- Lars\r
+> +\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + [ application/pgp-signature ]\r
+> + [ text/plain ]\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)\r
+> + Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)\r
+> + Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)\r
+> + Subject: Re: [notmuch] Working with Maildir storage?\r
+> + To: Keith Packard <keithp@keithp.com>\r
+> + Cc: notmuch@notmuchmail.org\r
+> + Date: Tue, 17 Nov 2009 19:50:40 -0500\r
+> +\r
+> + [ multipart/mixed ]\r
+> + [ multipart/signed ]\r
+> + [ text/plain ]\r
+> + > I've also pushed a slightly more complicated (and complete) fix to my\r
+> + > private notmuch repository\r
+> +\r
+> + The version of lib/messages.cc in your repo doesn't build because it's\r
+> + missing "#include <stdint.h>" (for the uint32_t on line 466).\r
+> +\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + [ application/pgp-signature ]\r
+> + [ text/plain ]\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)\r
+> diff --git a/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-on b/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-on\r
+> new file mode 100644\r
+> index 0000000..bafb479\r
+> --- /dev/null\r
+> +++ b/test/emacs.expected-output/notmuch-show-elide-non-matching-messages-on\r
+> @@ -0,0 +1,75 @@\r
+> +Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)\r
+> +Subject: [notmuch] Working with Maildir storage?\r
+> +To: notmuch@notmuchmail.org\r
+> +Date: Tue, 17 Nov 2009 14:00:54 -0500\r
+> +\r
+> +[ multipart/mixed ]\r
+> +[ multipart/signed ]\r
+> +[ text/plain ]\r
+> +I saw the LWN article and decided to take a look at notmuch. I'm\r
+> +currently using mutt and mairix to index and read a collection of\r
+> +Maildir mail folders (around 40,000 messages total).\r
+> +\r
+> +notmuch indexed the messages without complaint, but my attempt at\r
+> +searching bombed out. Running, for example:\r
+> +\r
+> + notmuch search storage\r
+> +\r
+> +Resulted in 4604 lines of errors along the lines of:\r
+> +\r
+> + Error opening\r
+> + /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:\r
+> + Too many open files\r
+> +\r
+> +I'm curious if this is expected behavior (i.e., notmuch does not work\r
+> +with Maildir) or if something else is going on.\r
+> +\r
+> +Cheers,\r
+> +\r
+> +[ 4-line signature. Click/Enter to show. ]\r
+> +[ application/pgp-signature ]\r
+> +[ text/plain ]\r
+> +[ 4-line signature. Click/Enter to show. ]\r
+> + Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)\r
+> + Subject: Re: [notmuch] Working with Maildir storage?\r
+> + To: Mikhail Gusarov <dottedmag@dottedmag.net>\r
+> + Cc: notmuch@notmuchmail.org\r
+> + Date: Tue, 17 Nov 2009 15:33:01 -0500\r
+> +\r
+> + [ multipart/mixed ]\r
+> + [ multipart/signed ]\r
+> + [ text/plain ]\r
+> + > See the patch just posted here.\r
+> +\r
+> + Is the list archived anywhere? The obvious archives\r
+> + (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I\r
+> + think I subscribed too late to get the patch (I only just saw the\r
+> + discussion about it).\r
+> +\r
+> + It doesn't look like the patch is in git yet.\r
+> +\r
+> + -- Lars\r
+> +\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + [ application/pgp-signature ]\r
+> + [ text/plain ]\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)\r
+> + Subject: Re: [notmuch] Working with Maildir storage?\r
+> + To: Keith Packard <keithp@keithp.com>\r
+> + Cc: notmuch@notmuchmail.org\r
+> + Date: Tue, 17 Nov 2009 19:50:40 -0500\r
+> +\r
+> + [ multipart/mixed ]\r
+> + [ multipart/signed ]\r
+> + [ text/plain ]\r
+> + > I've also pushed a slightly more complicated (and complete) fix to my\r
+> + > private notmuch repository\r
+> +\r
+> + The version of lib/messages.cc in your repo doesn't build because it's\r
+> + missing "#include <stdint.h>" (for the uint32_t on line 466).\r
+> +\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> + [ application/pgp-signature ]\r
+> + [ text/plain ]\r
+> + [ 4-line signature. Click/Enter to show. ]\r
+> -- \r
+> 1.7.8.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff