Re: [PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags of all messages...

diff --git a/c2/11b553b289674d390b55d20079aa1950c57b31 b/c2/11b553b289674d390b55d20079aa1950c57b31
new file mode 100644 (file)
index 0000000..d4a48d7
--- /dev/null
+++ b/c2/11b553b289674d390b55d20079aa1950c57b31
@@ -0,0 +1,104 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B405B431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KcIjNxhIPINw for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Oct 2012 19:15:35 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1F933431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:35 -0700 (PDT)\r
+Received: by mail-qc0-f181.google.com with SMTP id x40so5261487qcp.26\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 19:15:34 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=Ogpn6EadXLfkrvHZwU1dw49lqo/C+AUSkl7z8wHrTUc=;\r
+       b=BR2HPtIhi7nUQGjgu9OZrcO/H+Ss5zQBBvesrJfET3ElnYbR2fLemq+YT17Tl8zk0a\r
+       15Bw4+GHCyem7Mp6fMmi8/zsKlw2DEM6Rp0XG+G7vbihT6qM0EL9hx+iq4RY7zPLL4Qz\r
+       IP7fvkSTirsz1CfxmnzXvC12Efw/BqvWSflwgEZfoREVt+o6W9+KRexs34ieSsuk84o5\r
+       Utuq/LoBgkc29LLNuLp9W4R687huXkClHVkQBa1VifY0cpG/yTNikl4ZuXIPJd8pZLKF\r
+       FbBeFbyKgbp9G7LgaLAPO7+KOG0qJH128udNJrY5xfaVjfBwhTJJLpm9cTsAv2UcxA2F\r
+       F9EQ==\r
+Received: by 10.229.38.17 with SMTP id z17mr6729659qcd.30.1350353734438;\r
+       Mon, 15 Oct 2012 19:15:34 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id\r
+       ig20sm14207080qab.19.2012.10.15.19.15.31\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 15 Oct 2012 19:15:33 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+Subject: Re: [PATCH v2 2/6] test: emacs: new test "notmuch-show: change tags\r
+       of all messages in current buffer"\r
+In-Reply-To: <1330122640-18895-3-git-send-email-pieter@praet.org>\r
+References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>\r
+       <1330122640-18895-1-git-send-email-pieter@praet.org>\r
+       <1330122640-18895-3-git-send-email-pieter@praet.org>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 15 Oct 2012 22:15:30 -0400\r
+Message-ID: <87txtv88n1.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 16 Oct 2012 02:15:35 -0000\r
+\r
+Pieter Praet <pieter@praet.org> writes:\r
+\r
+> * test/emacs:\r
+>\r
+>   New subtest "notmuch-show: change tags of all messages in current buffer":\r
+>   `notmuch-show-tag-all' ("*") changes tags of *all* messages in current buffer.\r
+> ---\r
+>  test/emacs |   15 +++++++++++++++\r
+>  1 files changed, 15 insertions(+), 0 deletions(-)\r
+>\r
+> diff --git a/test/emacs b/test/emacs\r
+> index ec1dbb0..d2dbafc 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -136,6 +136,21 @@ test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+>  output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+>  test_expect_equal "$output" "thread:XXX   2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+>\r
+> +test_begin_subtest "notmuch-show: change tags of all messages in current buffer"\r
+> +query="$os_x_darwin_thread"\r
+> +filter="from:Jiang"\r
+> +add_tag="notmuch-show-tag-all"\r
+> +del_tag="inbox"\r
+> +count_total=$(notmuch count -- "$query")               # = 4\r
+> +count_match=$(notmuch count -- "$query" AND "$filter") # = 2\r
+\r
+In this test, what use is count_match? Just so that the tests' forms\r
+are the same? Maybe you want to put an assertion that count_total !=\r
+count_match, just for sanity's sake?\r
+\r
+Otherwise, patches 1-3 look fine to me.\r
+\r
+Ethan\r