Re: [PATCH 1/5] go: reorganize the go bindings

diff --git a/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f b/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f
new file mode 100644 (file)
index 0000000..ee835b3
--- /dev/null
+++ b/7b/0d75b2a535e68d9e4ba0df6820aece81c5cd8f
@@ -0,0 +1,98 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8D561431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 May 2012 04:16:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XM8BEVLGEvfZ for <notmuch@notmuchmail.org>;\r
+       Sat,  5 May 2012 04:16:49 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BBFC1431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  5 May 2012 04:16:49 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id 33CA6588B05\r
+       for <notmuch@notmuchmail.org>; Sat,  5 May 2012 13:16:45 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 92921DF2A3; Sat,  5 May 2012 13:16:44 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de\r
+ [10.1.1.155]) (using TLSv1 with cipher AES256-SHA (256/256 bits))     (No client\r
+ certificate requested) (Authenticated sender: teythoon)       by\r
+ mail.jade-hamburg.de (Postfix) with ESMTPSA id 6E39CDF2A0;    Sat,  5 May 2012\r
+ 13:16:39 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1SQcxb-0008Cg-Gx; Sat, 05 May 2012 13:15:35 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: Austin Clements <amdragon@MIT.EDU>, \r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To: <20120504184320.GO2704@mit.edu>\r
+References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>\r
+       <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <20120504183822.GN2704@mit.edu> <20120504184320.GO2704@mit.edu>\r
+Message-ID: <20120505111535.3687.9018@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3+\r
+Subject: Re: [PATCH 1/5] go: reorganize the go bindings\r
+Date: Sat, 05 May 2012 13:15:35 +0200\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 May 2012 11:16:50 -0000\r
+\r
+Quoting Austin Clements (2012-05-04 20:43:20)\r
+> Quoth myself on May 04 at  2:38 pm:\r
+> > Quoth Justus Winter on Apr 30 at  9:55 pm:\r
+> > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+> > =\r
+\r
+> > Whole series LGTM (and yay gofmt!).  I have only two minor comments.\r
+> > =\r
+\r
+> > It would be nice to have a little more log message for some of these.\r
+> > Mostly the first one could use some explanation of why you're\r
+> > rearranging the source tree and a mention that there are no changes to\r
+> > the files (since this is hard to get from the diff).\r
+\r
+Good point.\r
+\r
+> > It would also be nice if this could optionally be built using the\r
+> > libnotmuch and notmuch.h directly from the source tree containing the\r
+> > Go bindings, rather than requiring them to be installed system-wide.\r
+> > I don't know Go 1's build system well enough to know if there's an\r
+> > easy way to do this.\r
+\r
+Yes, I've been pondering that myself. There are CGO_CFLAGS and\r
+CGO_LDFLAGS that could be used to point the c compiler to the right\r
+paths. I'll experiment with this and propose a patch.\r
+\r
+> Oh, also a news patch would be good, though that can obviously be\r
+> separate.\r
+\r
+Sure.\r
+\r
+I'll send an updated patch series. Thanks for the review.\r
+\r
+Justus\r