--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 132B4431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Jun 2012 02:18:09 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 21mRUppGuMIL for <notmuch@notmuchmail.org>;\r
+ Wed, 27 Jun 2012 02:18:08 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 17016431FAF\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Jun 2012 02:18:08 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SjoNr-0006z6-NY; Wed, 27 Jun 2012 10:18:04 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SjoNr-0005hL-EI; Wed, 27 Jun 2012 10:17:59 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH 00/14] modular mail stores based on URIs\r
+In-Reply-To: <1340656899-5644-1-git-send-email-ethan@betacantrips.com>\r
+References: <1340656899-5644-1-git-send-email-ethan@betacantrips.com>\r
+User-Agent: Notmuch/0.13.2+63~g548a9bf (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 27 Jun 2012 10:17:54 +0100\r
+Message-ID: <877gutnmf1.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: e7aec02e93494fc172241b5418be4de1 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 27 Jun 2012 09:18:09 -0000\r
+\r
+\r
+Hi\r
+\r
+On Mon, 25 Jun 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote:\r
+\r
+> Hi guys,\r
+>\r
+> Sorry for dropping off the mailing list after I sent my last patch\r
+> series (http://notmuchmail.org/pipermail/notmuch/2012/009470.html). I\r
+> haven't had the time or a stable enough email address to really follow\r
+> notmuch development :)\r
+>\r
+> I signed onto #notmuch a week or two ago and asked what I would need\r
+> to do to get a feature like this one into mainline. j4ni told me that\r
+> he agreed with the feedback to my original patch series, and suggested\r
+> that I follow mjw1009's advice of having filenames encode all\r
+> information about mail storage transparently, and that this would\r
+> solve the problem with the original patch series of sprinkling mail\r
+> storage parameters all over the place. bremner suggested that he had\r
+> been thinking about how to support mbox or other multiple-message\r
+> archives, and also commented that he wasn't crazy about so much of the\r
+> API being in strings.\r
+>\r
+> Based on this advice, I decided to revise my approach to this\r
+> patchset, one that is based around the stated desire to work with mbox\r
+> formats. This approach, in contrast to the mailstore approach that\r
+> Michal Sojka proposed and I revised, encodes all mail access\r
+> information as URIs. These URIs are stored in Xapian the way that\r
+> relative paths are right now. Examples might be:\r
+>\r
+> maildir:///home/ethan/Mail/folder/cur/filename:2,S\r
+> mbox:///home/ethan/Mail/folder/file.mbox#byte-offset+lenght\r
+> couchdb://ethan:password@localhost:8080/some-doc-id\r
+\r
+First, thank you for resubmitting this: it is definitely a feature I\r
+would like to see in notmuch. And at a first glance I like the series\r
+(and I will try and review it over the next few days).\r
+\r
+> Personally, this isn't my favorite approach, for the following reasons:\r
+>\r
+> 1. Notmuch, at some point in its history, chose to store file paths\r
+> relative to a "mail database", with the intent that if this mail\r
+> database was moved, filenames would not change and everything would\r
+> Just Work (tm). The above scheme completely reverses this design\r
+> decision, and in general completely breaks this relocatability. I\r
+> don't see any easy way to handle this problem. This isn't just a\r
+> wishlist feature; at least two things in the test suite (caching of\r
+> corpus.mail, and the atomicity tests) rely on this behavior.\r
+\r
+Why can't the URI just store a relative path, at least for maildir://\r
+and mbox:// ? It is purely internal to notmuch so it doesn't need to be\r
+very standard.\r
+\r
+> 2. Mail access information, i.e. open connections, etc. can only be\r
+> stored in variables global to the mailstore code, and cannot be stored\r
+> as private members of a mailstore object. This is more an aesthetic\r
+> concern than a functional one.\r
+>\r
+> Anyhow, the following (enormous) patch series implement this design. I\r
+> used uriparser as an external library to parse URIs. The API for this\r
+> library is a little idiosyncratic. uriparser supports parsing Unicode\r
+> URIs (strings of wchar_t), but I just used ASCII filenames because I\r
+> think that's what comes out of Xapian.\r
+\r
+Why use a library? Isn't it just a question of does the string contain\r
+// and, if so, splitting it? I guess that // is a nice separator as I\r
+think we can assume that a true path does not contain it (since a\r
+filename cannot contain /).\r
+\r
+> Patch 11 is borrowed directly from the last patch series.\r
+>\r
+> The last four or five patches add mbox support, including a few\r
+> tests. That part of the series is still very first-draft: I added a\r
+> new config option to specify URIs to scan, and ">From " lines still\r
+> need to be unescaped. However, we support scanning mbox files whether\r
+> messages have content-length or not.\r
+\r
+I have an idea that mbox byte-locations change when messages are marked\r
+as read (amongst other things). It might be worth saying that this\r
+initial implementation only works for unchanging mboxs (rather than the\r
+append only condition that you currently say). But I have not got as far\r
+as applying/testing the series yet.\r
+\r
+> I will try to receive feedback on this series more gratefully than the\r
+> last one. :)\r
+\r
+Just to say all of the above are genuine questions (not requests for you\r
+to rewrite stuff!) to try and understand the series.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
projects / notmuch-archives.git / commitdiff