Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected

diff --git a/ae/ba82d5f30f4de5a5a5a013b802ab0aa1b9d6ea b/ae/ba82d5f30f4de5a5a5a013b802ab0aa1b9d6ea
new file mode 100644 (file)
index 0000000..91d4827
--- /dev/null
+++ b/ae/ba82d5f30f4de5a5a5a013b802ab0aa1b9d6ea
@@ -0,0 +1,85 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0F333431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id e6NTR5+YeGWs for <notmuch@notmuchmail.org>;\r
+       Thu, 18 Oct 2012 20:55:46 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+       [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6A261431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:46 -0700 (PDT)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so40924vbb.26\r
+       for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 20:55:45 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=h40uiBQEZojm1y1Y1lvmt3SBNoHLkbx/6MzR95f2XuY=;\r
+       b=JFpWp5Yyro52w4bx4K1HAwdFv46i8tC2991tr7wMbFk89+6RS9estq+8blXvX/61hd\r
+       rggCDLDZIpqQhQxkgDDSF/u83q7MjrwwWDXlp76igYxSL3+OQ0PvM7pS+QdTijsj6eFy\r
+       n50zqD5bcc8aeLCpZz/pIUYIwHZ2Lk8t8NdC9vMfARGJEq3nZfNTsLj68yy6FWhhItEu\r
+       pfAkC1zSUX8Ngqp37fLCsy0tmfThtUYLHbT7/tVDMqIvE3uQsVg+ZlpF0chHRxNCDwFG\r
+       s8MdAa/P43xjGgW80VjE0gIdGLMF8pExdK014nHvpLOAXJNw0lmqgfsdI2QdDIAwkkl5\r
+       ADrA==\r
+Received: by 10.52.23.225 with SMTP id p1mr14645207vdf.79.1350618945742;\r
+       Thu, 18 Oct 2012 20:55:45 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id zx18sm615107veb.3.2012.10.18.20.55.43\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 18 Oct 2012 20:55:43 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Adrien Bustany <adrien@bustany.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected\r
+In-Reply-To: <1342636475-16057-4-git-send-email-adrien@bustany.org>\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+       <1342636475-16057-4-git-send-email-adrien@bustany.org>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 18 Oct 2012 23:55:40 -0400\r
+Message-ID: <87wqyn6rpf.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Oct 2012 03:55:47 -0000\r
+\r
+Adrien Bustany <adrien@bustany.org> writes:\r
+\r
+> This makes notmuch appropriately free the underlying notmuch C objects\r
+> when garbage collecting their Go wrappers. To make sure we don't break\r
+> the underlying links between objects (for example, a notmuch_messages_t\r
+> being GC'ed before a notmuch_message_t belonging to it), we add for each\r
+> wraper struct a pointer to the owner object (Go objects with a reference\r
+> pointing to them don't get garbage collected).\r
+\r
+Hi Adrien! This whole series is marked moreinfo, but I don't think\r
+that's just. It looks like there were some unresolved issues about\r
+reference tracking and garbage collection, and some suggestions to use\r
+the C values of enums instead of regenerating them with iota, but\r
+there's definitely valid code that I assume would be useful if anyone\r
+ever wanted to write in Go ;). Are you figuring to clean this series up?\r
+\r
+This comment should s/wraper/wrapper/.\r
+\r
+Ethan\r