Re: [PATCH 2/3] notmuch-restore: tidy formatting

diff --git a/7a/46249c38e6a439d4187a4944b50443468d8cbb b/7a/46249c38e6a439d4187a4944b50443468d8cbb
new file mode 100644 (file)
index 0000000..b132fc5
--- /dev/null
+++ b/7a/46249c38e6a439d4187a4944b50443468d8cbb
@@ -0,0 +1,83 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 98E27431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:21:45 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id pKwCz1OC+p-7 for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Nov 2012 07:21:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63926431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:21:44 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id EA4361000E2;\r
+       Thu, 15 Nov 2012 17:21:43 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/3] notmuch-restore: tidy formatting\r
+In-Reply-To: <1352943202-1431-3-git-send-email-david@tethera.net>\r
+References: <1352943202-1431-1-git-send-email-david@tethera.net>\r
+       <1352943202-1431-3-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 15 Nov 2012 17:21:43 +0200\r
+Message-ID: <m2mwyix56g.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 15 Nov 2012 15:21:45 -0000\r
+\r
+On Thu, Nov 15 2012, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> This is again the work of uncrustify.\r
+>\r
+> I remember there is some controversy about "! foo" versus "!foo", but\r
+> in context I think "! foo" looks OK. Also, for functions "! foo\r
+> (blah)" seems better than "!foo (blah)".\r
+\r
+Currently:\r
+$ egrep '! ' *.c | wc\r
+     19     108    1074\r
+$ egrep '![^ =]' *.c | wc \r
+     41     250    2223\r
+\r
+Anyway IIRC Carl preferred the ! foo format and the code might\r
+have drifted away from that...\r
+\r
+Whatever this choice will eventually be for "pure" notmuch code\r
+should not affect what the code that can be considered as\r
+external libraries should be formatted; e.g. parse-time-string\r
+code should keep the formatting Jani prefers.\r
+\r
+The uncrustify.cfg option 'sp_not' affects whether there is\r
+space after ! or not -- and it can even be configured to 'ignore'\r
+this case.\r
+\r
+Tomi\r
+\r
+// patch dropped.\r