Tweak emerge --quiet-build default handling.
authorZac Medico <zmedico@gentoo.org>
Thu, 17 Nov 2011 01:38:48 +0000 (17:38 -0800)
committerZac Medico <zmedico@gentoo.org>
Thu, 17 Nov 2011 01:38:48 +0000 (17:38 -0800)
Since --quiet-build is enabled be default, there's no need to have it
in the options dict except when it is enabled.

pym/_emerge/Scheduler.py
pym/_emerge/main.py

index cb4aab4cda3ed26aa5d770f099a7bbcd5392d4ba..47f7c4591c17fcd24889bc0903ca1dcccb24d7b5 100644 (file)
@@ -386,7 +386,7 @@ class Scheduler(PollScheduler):
                """
                background = (self._max_jobs is True or \
                        self._max_jobs > 1 or "--quiet" in self.myopts \
-                       or "--quiet-build" in self.myopts) and \
+                       or self.myopts.get("--quiet-build", "y") == "y") and \
                        not bool(self._opts_no_background.intersection(self.myopts))
 
                if background:
index a2995e2b7eddf0662c2ef3411fc7e10f896178a3..5e9f13e3c21ffdacd059280ee57b069877d297fc 100644 (file)
@@ -848,7 +848,6 @@ def parse_opts(tmpcmdline, silent=False):
                        "help"     : "redirect build output to logs",
                        "type"     : "choice",
                        "choices"  : true_y_or_n,
-                       "default"  : "y",
                },
 
                "--rebuild-if-new-rev": {
@@ -1092,8 +1091,6 @@ def parse_opts(tmpcmdline, silent=False):
                myoptions.quiet = None
 
        if myoptions.quiet_build in true_y:
-               myoptions.quiet_build = True
-       else:
                myoptions.quiet_build = None
 
        if myoptions.rebuild_if_new_ver in true_y: