Re: [PATCH v2 1/3] Add 'compose' command

diff --git a/21/e73e26b9204e2454c547a1854a6a811ede0883 b/21/e73e26b9204e2454c547a1854a6a811ede0883
new file mode 100644 (file)
index 0000000..b582ab9
--- /dev/null
+++ b/21/e73e26b9204e2454c547a1854a6a811ede0883
@@ -0,0 +1,108 @@
+Return-Path: <felipe.contreras@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4F88F431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 08:39:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 528QkK-eErtN for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Apr 2012 08:39:22 -0700 (PDT)\r
+Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com\r
+ [74.125.83.53])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 068BC431FAE   for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 08:39:21 -0700\r
+ (PDT)\r
+Received: by eekb47 with SMTP id b47so3111031eek.26\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 08:39:20 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+       :cc:content-type;\r
+       bh=et3K0CKuN0W1n+5jho3NmikhnS9RrMxhw4NImYybndE=;\r
+       b=FJJMVgdJ9Ge/ukIuHX+AnOch+wGkCGGbLfSydmWeIBEzhJNSxCL8WEQDklZOFpC6u+\r
+       htEoNdSJP2I57+zWMBWmpzzVX4mlQsdNbsqeuO6Kf/wFduGR8zvw7MMJdqt+vmMhdtab\r
+       0vZkGpehkPxnCwQHECGQInLUoAjK3frfSixctFod79GgI0dRCA7s3ih5yz8uf2DxVMCQ\r
+       JyHeLyjIBNaJzkqp3rU0GS4uFRHqjAwoAfywrTo+t8nWSVKRZoxFg0gWSPuXlFTysfkV\r
+       I2/pQ9vbVY5uJtPYLB6OwDNNRkhOO4jFnFoCgLR/p2Qw0t6Fx8W8vguO9Y0O4gUznIHY\r
+       KpyQ==\r
+MIME-Version: 1.0\r
+Received: by 10.213.104.132 with SMTP id p4mr252938ebo.101.1334763560806; Wed,\r
+       18 Apr 2012 08:39:20 -0700 (PDT)\r
+Received: by 10.213.19.67 with HTTP; Wed, 18 Apr 2012 08:39:20 -0700 (PDT)\r
+In-Reply-To: <87vckxazq7.fsf@nikula.org>\r
+References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>\r
+       <1334752753-23970-2-git-send-email-felipe.contreras@gmail.com>\r
+       <873981chpj.fsf@nikula.org>\r
+       <CAMP44s2Ukz=kDaPHYG+jzR3pDfZGP+6Ojqc4Xz5J8PxEd9fKcQ@mail.gmail.com>\r
+       <87vckxazq7.fsf@nikula.org>\r
+Date: Wed, 18 Apr 2012 18:39:20 +0300\r
+Message-ID:\r
+ <CAMP44s1117VXAOnURjFAeva93oiJsKKPji4awN_SoNFo0QvPPw@mail.gmail.com>\r
+Subject: Re: [PATCH v2 1/3] Add 'compose' command\r
+From: Felipe Contreras <felipe.contreras@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>\r
+Content-Type: text/plain; charset=UTF-8\r
+Cc: Felipe Contreras <felipe.contreras@ngmail.com>, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Apr 2012 15:39:26 -0000\r
+\r
+On Wed, Apr 18, 2012 at 5:20 PM, Jani Nikula <jani@nikula.org> wrote:\r
+> On Wed, 18 Apr 2012 16:34:30 +0300, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula <jani@nikula.org> wrote:\r
+>>\r
+>> > Running "notmuch compose" more than once within a second would result in\r
+>> > identical message ids for the messages, which is not a good idea. That's\r
+>> > not likely in interactive use, but the notmuch cli is highly scriptable,\r
+>> > so someone is bound to hit this.\r
+>> >\r
+>> > Some paranoid might also be worried about "leaking" the time you run\r
+>> > "notmuch compose"... which may be different from the actual time you\r
+>> > send the message.\r
+>>\r
+>> It's still better than the current situation; nothing. In any case,\r
+>> people that have not needed this would not be affected; their UI would\r
+>> override the Message-ID.\r
+>>\r
+>> So do you have a better suggestion for a Message-ID?\r
+>\r
+> The easy way would be to just use g_mime_utils_generate_message_id()\r
+> [1]. It doesn't give you any control of the part before @, but I'm not\r
+> sure if that really matters.\r
+\r
+This is what gmime does:\r
+g_strdup_printf ("%lu.%lu.%lu@%s", (unsigned long int) time (NULL),\r
+(unsigned long int) getpid (), count++, fqdn);\r
+\r
+Which actually has some of the issues you mentioned.\r
+\r
+I can do the same if you want (add pid and count). The advantage of\r
+using our own format is that not only would it be more unique, but it\r
+would not have "@fqdn".\r
+\r
+> Alternatively you can write your own according to e.g. [2]. Glib appears\r
+> to have decent and portable support for pseudo random number\r
+> generation. But why bother? I'd go with gmime.\r
+\r
+But gmime doesn't have anything random. I would actually prefer to\r
+have something random though.\r
+\r
+-- \r
+Felipe Contreras\r