Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

diff --git a/52/57a772bcc86632e8b820b757ab9716006026ce b/52/57a772bcc86632e8b820b757ab9716006026ce
new file mode 100644 (file)
index 0000000..3a05043
--- /dev/null
+++ b/52/57a772bcc86632e8b820b757ab9716006026ce
@@ -0,0 +1,115 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5923A431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:30:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id jMPlOFCFekqi for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Apr 2012 02:30:28 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7DCCF431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:30:28 -0700 (PDT)\r
+Received: by qcsk26 with SMTP id k26so4634033qcs.26\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Apr 2012 02:30:27 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=HqUQckzPItOR1oG4QbhLYa6zTmeH8btH1M+KmDuBlHk=;\r
+       b=GaOAUzRPnm5f0fNReLDqnk4glgTOw40z2jlis7uW7/+xc62xGB0/ZB6+U0o1Njent8\r
+       gJ4jHzol/lpSwOYTa47g99uZFWWyhyfFO9BEw6ae8qqyWJFnELECpL/VMfYTVN6jXB1W\r
+       8jV8wpFjusacc2kq0zhZ8lmU3CzZHi6d9mMQpLAo38sRJUlRGlfl8mu2mPynXjrILUmJ\r
+       R4P0T19ZvjruFRHnl0x1SK+odLZtVf96Sg32PCrXzW/UjTc+xFyISse4+LEDSquP6i2/\r
+       jeMtTiMwq4LhgtUXlLXg+TFK/c8RrKVB7dMpLiu0pP3+QfAK9xWsv3s2YIEtQh24j+LV\r
+       bZ2A==\r
+Received: by 10.229.135.209 with SMTP id o17mr1459884qct.152.1334655027784;\r
+       Tue, 17 Apr 2012 02:30:27 -0700 (PDT)\r
+Received: from localhost (nikula.org. [92.243.24.172])\r
+       by mx.google.com with ESMTPS id fo9sm39250891qab.21.2012.04.17.02.30.26\r
+       (version=SSLv3 cipher=OTHER); Tue, 17 Apr 2012 02:30:27 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to\r
+       notmuch-hello-refresh-hook\r
+In-Reply-To: <877gxeohh6.fsf@gmail.com>\r
+References:\r
+ <bcfdc0d1969997e89e5abe0b320d77ee2109796a.1334651669.git.jani@nikula.org>\r
+       <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org>\r
+       <877gxeohh6.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1\r
+       (i686-pc-linux-gnu)\r
+Date: Tue, 17 Apr 2012 09:30:24 +0000\r
+Message-ID: <87hawivh73.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQko6/OkeJD6f3KlQR+sA0qlTeX3vh8XNxNF6jyZncEWe6gNwlN8xb1YAmibea5UuxP/4jkf\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Apr 2012 09:30:32 -0000\r
+\r
+On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> Can you please give some explanaition why is this needed?  Would this\r
+> change break custom hooks that do not expect any arguments?\r
+\r
+For patch 3/4. We don't want to display a message if someone calls\r
+(notmuch-hello-update t) from some script, and notmuch-hello buffer\r
+isn't even visible.\r
+\r
+Yes, it would break custom hooks. And a bunch of tests. But I think it\r
+would be useful for custom hooks too, for the same reason as above.\r
+\r
+Jani.\r
+\r
+\r
+\r
+> \r
+> Regards,\r
+>   Dmitry\r
+> \r
+> Jani Nikula <jani@nikula.org> writes:\r
+> \r
+> > ---\r
+> >  emacs/notmuch-hello.el |    2 +-\r
+> >  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> > index 9cd907a..0596bbe 100644\r
+> > --- a/emacs/notmuch-hello.el\r
+> > +++ b/emacs/notmuch-hello.el\r
+> > @@ -776,7 +776,7 @@ following:\r
+> >      (widget-setup)\r
+> >  \r
+> >      (goto-char final-target-pos))\r
+> > -  (run-hooks 'notmuch-hello-refresh-hook)\r
+> > +  (run-hook-with-args 'notmuch-hello-refresh-hook no-display)\r
+> >    (setq notmuch-hello-first-run nil))\r
+> >  \r
+> >  (defun notmuch-folder ()\r
+> > -- \r
+> > 1.7.1\r
+> >\r
+> > _______________________________________________\r
+> > notmuch mailing list\r
+> > notmuch@notmuchmail.org\r
+> > http://notmuchmail.org/mailman/listinfo/notmuch\r