Re: [PATCH v2 1/5] util: Factor out boolean term quoting routine

diff --git a/58/4bb67185b9a5dd085ec78a7805c65f8eaf82f8 b/58/4bb67185b9a5dd085ec78a7805c65f8eaf82f8
new file mode 100644 (file)
index 0000000..ddfc195
--- /dev/null
+++ b/58/4bb67185b9a5dd085ec78a7805c65f8eaf82f8
@@ -0,0 +1,74 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 729E7431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 06:25:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fGUCPor3HENZ for <notmuch@notmuchmail.org>;\r
+       Wed, 26 Dec 2012 06:25:02 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E1276431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 26 Dec 2012 06:25:01 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tnrul-0002TV-Eu; Wed, 26 Dec 2012 10:24:59 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1Tnrud-0005uN-Hl; Wed, 26 Dec 2012 10:24:51 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/5] util: Factor out boolean term quoting routine\r
+In-Reply-To: <1356493723-11085-2-git-send-email-amdragon@mit.edu>\r
+References: <1356493723-11085-1-git-send-email-amdragon@mit.edu>\r
+       <1356493723-11085-2-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 26 Dec 2012 10:24:51 -0400\r
+Message-ID: <87lickrivg.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 26 Dec 2012 14:25:02 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> +/* Construct a boolean term query with the specified prefix (e.g.,\r
+> + * "id") and search term, quoting term as necessary.\r
+> + *\r
+> + * Output is into buf; it may be talloc_realloced.\r
+> + * Return: 0 on success, non-zero on memory allocation failure.\r
+> + */\r
+> +int make_boolean_term (void *talloc_ctx, const char *prefix, const char *term,\r
+> +                   char **buf, size_t *len);\r
+> +\r
+\r
+I think the quoting should be described a bit more precisely here,\r
+especially since you are going to refer to it in the comment above\r
+parse_boolean_term.\r
+\r
+d\r