Re: [PATCH 0/3] Rewrite default reply format

diff --git a/ae/b4e796d96ed4585b95c7e0ca37a7809f98c8c0 b/ae/b4e796d96ed4585b95c7e0ca37a7809f98c8c0
new file mode 100644 (file)
index 0000000..7e23b13
--- /dev/null
+++ b/ae/b4e796d96ed4585b95c7e0ca37a7809f98c8c0
@@ -0,0 +1,114 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 948C9431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id s4HEjwPW0Ytm for <notmuch@notmuchmail.org>;\r
+       Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1BCCE431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 14:57:25 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-91-4f7237c44618\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 07.FC.02234.4C7327F4; Tue, 27 Mar 2012 17:57:24 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q2RLvNaQ022696; \r
+       Tue, 27 Mar 2012 17:57:23 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2RLvKQc013697\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 27 Mar 2012 17:57:22 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SCeOG-0002Dr-30; Tue, 27 Mar 2012 17:57:20 -0400\r
+Date: Tue, 27 Mar 2012 17:57:20 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 0/3] Rewrite default reply format\r
+Message-ID: <20120327215720.GX2670@mit.edu>\r
+References: <1332473647-9133-1-git-send-email-amdragon@mit.edu>\r
+       <m2d382ia9d.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2d382ia9d.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j1iXuRvcPoTn8X1mzOZLd6snMfq\r
+       wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGX8/NnMUjCDs6J39SaWBsY57F2MnBwSAiYS\r
+       8y4sZYSwxSQu3FvP1sXIxSEksI9RouX0JDaQhJDABkaJ3xsyIRInmSRaD+6CSixhlFi7UxvE\r
+       ZhFQlbjTdYgZxGYT0JDYtn852FQRARWJB23rWUFsZgFpiW+/m5lAbGEBU4lZa+6DXcEroC2x\r
+       8NEWJoiZqRIrD6xghogLSpyc+YQFoldL4sa/l0A1HGBzlv/jAAlzChhI/PzxAmy8KNCqKSe3\r
+       sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Rrp5WaW6KWmlG5iBAe1\r
+       JO8OxncHlQ4xCnAwKvHwVjMV+QuxJpYVV+YeYpTkYFIS5VUwBQrxJeWnVGYkFmfEF5XmpBYf\r
+       YpTgYFYS4dWOKvQX4k1JrKxKLcqHSUlzsCiJ86pqvfMTEkhPLEnNTk0tSC2CycpwcChJ8PIB\r
+       o1dIsCg1PbUiLTOnBCHNxMEJMpwHaPhnM6Aa3uKCxNzizHSI/ClGRSlx3o8gCQGQREZpHlwv\r
+       LOm8YhQHekWY9xtIFQ8wYcF1vwIazAQ0eMmRfJDBJYkIKakGxv3zZtTdC//h+mlx0bL2XNUr\r
+       050rn8WlTdWb6PYulO9PJuvXyMrTG84cyXCxZD7oNyvfgDk9bqVh2c+ttc/DK72THtenhS00\r
+       r4jacH3bOoFV8amMn3Z1hbKHP5mtMbvotb0J0+8y13xGKfuq+Ts8tJTEH1/Kkha9wfO8TGx6\r
+       wALtbcFvd/cnKbEUZyQaajEXFScCAJEwQKEVAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 27 Mar 2012 21:57:25 -0000\r
+\r
+Thanks for the review.  New version coming shortly...\r
+\r
+Quoth Tomi Ollila on Mar 24 at 12:06 pm:\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+> \r
+> > The default reply format is the last bastion of the old message\r
+> > formatter style.  This series converts it to the new self-recursive\r
+> > style.  After this, there will be one last series to rip out the\r
+> > compatibility code and do final cleanup.\r
+> \r
+> Works fine, patches look good... just 2 "spacing" questions:\r
+> \r
+> in id:"1332473647-9133-2-git-send-email-amdragon@mit.edu"\r
+> \r
+> + typedef enum {\r
+> +     NOTMUCH_SHOW_TEXT_PART_REPLY = 1<<0,\r
+> + } notmuch_show_text_part_flags;\r
+> \r
+> Should this be like: NOTMUCH_SHOW_TEXT_PART_REPLY = (1 << 0),\r
+\r
+Changed to NOTMUCH_SHOW_TEXT_PART_REPLY = 1 << 0 to be consistent with\r
+operator spacing.  I left out the parens since they aren't necessary.\r
+\r
+> and this\r
+> \r
+> + * If flags&NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each\r
+> + * output line.\r
+> + *\r
+> \r
+> like:\r
+> \r
+> + * If flags & NOTMUCH_SHOW_TEXT_PART_REPLY, this prepends "> " to each\r
+\r
+Changed.  On this one I put in parens to better distinguish it from\r
+the surrounding prose.\r
+\r
+> Tomi\r