Re: [PATCH v2 (Draft)] emacs: split async json parser into utility function

diff --git a/49/90ebc764cb3215e4700f2674a524e0d02b6b6c b/49/90ebc764cb3215e4700f2674a524e0d02b6b6c
new file mode 100644 (file)
index 0000000..44a887c
--- /dev/null
+++ b/49/90ebc764cb3215e4700f2674a524e0d02b6b6c
@@ -0,0 +1,78 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7467F431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Sep 2012 08:51:17 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ufYernDCprE0 for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Sep 2012 08:51:17 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0068E431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Sep 2012 08:51:16 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T8CSB-0008FC-EX; Sun, 02 Sep 2012 12:51:15 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T8CS5-0008Cf-TE; Sun, 02 Sep 2012 12:51:09 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH v2 (Draft)] emacs: split async json parser into utility\r
+       function\r
+In-Reply-To: <87k3xlyoek.fsf@qmul.ac.uk>\r
+References: <87k3xo85tv.fsf@qmul.ac.uk> <20120730013506.GF8502@mit.edu>\r
+       <87obmxyokt.fsf@qmul.ac.uk> <87k3xlyoek.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 02 Sep 2012 12:51:09 -0300\r
+Message-ID: <87vcfw779u.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Sep 2012 15:51:17 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> Split out the json parser into a utility function.\r
+> ---\r
+>\r
+> Most of this patch is code movement: but I don't see how to arrange the\r
+> patch to show that.\r
+>\r
+\r
+"git gui blame notmuch.el" gives some clues, although it isn't perfect.\r
+Maybe you could explain in the commit message what is _not_ code\r
+movement?\r
+\r
+> +(defvar notmuch-json-parser nil\r
+> +  "Incremental JSON parser.")\r
+\r
+This docstring needs expanding. I suppose that this is for internal use,\r
+but it isn't clear from the docstring.\r
+\r