Re: [PATCH] test: make test_expect_equal_file() arguments flexible

diff --git a/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 b/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2
new file mode 100644 (file)
index 0000000..945f1a3
--- /dev/null
+++ b/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2
@@ -0,0 +1,75 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 53591431E64\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 00:55:48 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id aY+w65I2oZuz for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 00:55:47 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id BEAE1431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 00:55:47 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 920B468055; Wed,  1 Feb 2012 10:55:50 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible\r
+In-Reply-To: <87r4yfszx9.fsf@servo.finestructure.net>\r
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87r4yfszx9.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 01 Feb 2012 10:55:50 +0200\r
+Message-ID: <m28vknaq5l.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 08:55:48 -0000\r
+\r
+On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> On Wed,  1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > The down side of this approach is that diff argument order depends on\r
+> > test_expect_equal_file() argument order.  So sometimes we get diff\r
+> > from expected to actual results, and sometimes the other way around.\r
+> > But the files are always named correctly.\r
+> \r
+> Actually, I think this last point is the most important thing to retain.\r
+> Consistency in the diffs makes reading test results much more efficient.\r
+> The order I don't much care about.  But seeing as we have been\r
+> consistent with a particular order for a while, it seems like more\r
+> effort than it's worth to change it.\r
+\r
+how about enforcing it in the test suite ?\r
+\r
+case $file2 in \r
+       *.expected|*.EXPECTED) ;; \r
+        *) echo "$file2" does not end with 'expected' >&2; exit 1\r
+esac\r
+\r
+> \r
+> jamie.\r
+\r
+Tomi\r