ruby-fakegem.eclass: Remove completely unnecessary 'eval ls'
authorMichał Górny <mgorny@gentoo.org>
Thu, 23 Feb 2017 18:20:01 +0000 (19:20 +0100)
committerMichał Górny <mgorny@gentoo.org>
Wed, 8 Mar 2017 07:35:33 +0000 (08:35 +0100)
Filename expansion is performed when the variable is referenced unquoted
already. There is really no need to call 'ls' on top of that, and even
less reason to wrap it all in 'eval'.

eclass/ruby-fakegem.eclass

index 69ab29f7fb8526be5afb07a23f479f818ca0ea1b..b1795fa46c93fd27fd93ddf1450118bd0ab4582e 100644 (file)
@@ -521,9 +521,8 @@ all_fakegem_install() {
 
                if [[ -d "${bindir}" ]]; then
                        pushd "${bindir}" &>/dev/null || die
-                       local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP})
-                       for binary in $binaries; do
-                               ruby_fakegem_binwrapper $binary
+                       for binary in ${RUBY_FAKEGEM_BINWRAP}; do
+                               ruby_fakegem_binwrapper "${binary}"
                        done
                        popd &>/dev/null || die
                fi