app-mobilephone/smssend, dev-libs/skyutils: fix SSLv3 support.
authorMichael Orlitzky <mjo@gentoo.org>
Sun, 7 Aug 2016 22:26:57 +0000 (18:26 -0400)
committerMichael Orlitzky <mjo@gentoo.org>
Sun, 7 Aug 2016 22:32:19 +0000 (18:32 -0400)
In commits 790eacc and ac28332, I added an "sslv3" USE flag to
dev-libs/skyutils and revisioned app-mobilephone/smssend to depend on
it. This fix was insufficient; any other programs linking to
libskyutils would suffer the same problem, as Michał Górny pointed
out.

Two new revisions of the affected packages remove the "sslv3" option
for dev-libs/skyutils, and make it depend on openssl[sslv3] when the
user asks for SSL support. Note: this required the removal of LibreSSL
support on skyutils. The new revision of app-mobilephone/smssend now
depends on the fixed revision of skyutils.

An additional fix was made, and now smssend depends on
skyutils[ssl]. Without SSL support in libskyutils, many SMS providers
simply don't work.

Gentoo-Bug: 588326

app-mobilephone/smssend/smssend-3.4-r2.ebuild [moved from app-mobilephone/smssend/smssend-3.4-r1.ebuild with 80% similarity]
dev-libs/skyutils/metadata.xml
dev-libs/skyutils/skyutils-2.8-r5.ebuild [moved from dev-libs/skyutils/skyutils-2.8-r4.ebuild with 81% similarity]

similarity index 80%
rename from app-mobilephone/smssend/smssend-3.4-r1.ebuild
rename to app-mobilephone/smssend/smssend-3.4-r2.ebuild
index 287ac04eec6f65f3411854f539298ae3e2a1694f..be95746e2cd30b668e77191bf43527048340ac49 100644 (file)
@@ -16,7 +16,9 @@ SLOT="0"
 KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
 IUSE=""
 
-DEPEND=">=dev-libs/skyutils-2.7[sslv3]"
+# -r5 of skyutils fixes a runtime crash, bug 588326.
+# Without SSL support in skyutils, some providers fail.
+DEPEND=">=dev-libs/skyutils-2.8-r5[ssl]"
 RDEPEND="${DEPEND}"
 
 PATCHES=( "${FILESDIR}/${P}-verizon.diff" )
index deb5277467ee97c059568ad3fc0ebd322872785b..209c459554adc0d5566af09f7c2c8fb5a8809bd2 100644 (file)
@@ -6,10 +6,4 @@
     This library contains many useful functions such as chained lists,
     string manipulation, socket, and the HTTP protocol.
   </longdescription>
-
-  <use>
-    <flag name="sslv3">
-      Require OpenSSL to be built with the old SSLv3 protocol enabled.
-    </flag>
-  </use>
 </pkgmetadata>
similarity index 81%
rename from dev-libs/skyutils/skyutils-2.8-r4.ebuild
rename to dev-libs/skyutils/skyutils-2.8-r5.ebuild
index 252add28bbd8f5b66eb5679ace800e8c83f54f6c..48c855e6d5e4e35a4bf55f42b297d0ee566118a8 100644 (file)
@@ -13,13 +13,9 @@ SRC_URI="mirror://gentoo/${P}.tar.gz"
 LICENSE="LGPL-2.1+"
 SLOT="0"
 KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
-IUSE="libressl ssl sslv3"
-REQUIRED_USE="sslv3? ( ssl? ( !libressl ) )"
+IUSE="ssl"
 
-DEPEND="ssl? (
-       !libressl? ( dev-libs/openssl:0=[sslv3?] )
-       libressl? ( dev-libs/libressl:0= )
-)"
+DEPEND="ssl? ( dev-libs/openssl:0=[sslv3] )"
 RDEPEND="${DEPEND}"
 
 PATCHES=(