Re: [PATCH 4/4] Explicitly type void* pointers

diff --git a/12/eacf67d0994361bb44f97f19500e2c7e6ec77b b/12/eacf67d0994361bb44f97f19500e2c7e6ec77b
new file mode 100644 (file)
index 0000000..77b4b7e
--- /dev/null
+++ b/12/eacf67d0994361bb44f97f19500e2c7e6ec77b
@@ -0,0 +1,91 @@
+Return-Path: <Vladimir.Marek@Oracle.COM>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F3FA8431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 23:54:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -4.999\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-4.999 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_HI=-5, UNPARSEABLE_RELAY=0.001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2+4Yw0MuJnh8 for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Apr 2012 23:54:02 -0700 (PDT)\r
+Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 987B7431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Apr 2012 23:54:02 -0700 (PDT)\r
+Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237])\r
+       by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with\r
+       ESMTP id q3A6rwXE015063\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\r
+       Tue, 10 Apr 2012 06:54:01 GMT\r
+Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158])\r
+       by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id\r
+       q3A6ruBb003807\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\r
+       Tue, 10 Apr 2012 06:53:57 GMT\r
+Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71])\r
+       by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id\r
+       q3A6rt7P003195; Tue, 10 Apr 2012 01:53:55 -0500\r
+Received: from pub.czech.sun.com (/10.163.20.32)\r
+       by default (Oracle Beehive Gateway v4.0)\r
+       with ESMTP ; Mon, 09 Apr 2012 23:53:54 -0700\r
+Date: Tue, 10 Apr 2012 08:53:24 +0200\r
+From: Vladimir Marek <Vladimir.Marek@Oracle.COM>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH 4/4] Explicitly type void* pointers\r
+Message-ID: <20120410065324.GD10554@pub.czech.sun.com>\r
+Mail-Followup-To: Jani Nikula <jani@nikula.org>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+References: <1333966665-10469-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <1333966665-10469-5-git-send-email-Vladimir.Marek@oracle.com>\r
+       <CAB+hUn_QyMAfC1-Dr23T63ObX=cwuBOzcyCi=61w0MtGRMyt2w@mail.gmail.com>\r
+       <20120409181543.GC10554@pub.czech.sun.com>\r
+       <87mx6ka8y1.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Disposition: inline\r
+In-Reply-To: <87mx6ka8y1.fsf@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Source-IP: acsinet21.oracle.com [141.146.126.237]\r
+X-Auth-Type: Internal IP\r
+X-CT-RefId: str=0001.0A090202.4F83D909.0069,ss=1,re=0.000,fgs=0\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 Apr 2012 06:54:03 -0000\r
+\r
+[...]\r
+\r
+> I'm throwing in a third alternative below. Does it work for you? I think\r
+> it's both prettier and uglier than the above at the same time! ;)\r
+> \r
+> A middle ground would be to change the callers to use\r
+> "notmuch_talloc_steal", and just #define notmuch_talloc_steal\r
+> talloc_steal if __GNUC__ >= 3.\r
+> \r
+> One could argue upstream talloc should have this, but OTOH it's a C\r
+> library.\r
+\r
+That's a nice trick, and it indeed works for me. And I like it more than\r
+what I suggested.\r
+\r
+Thank you\r
+-- \r
+       Vlad\r