Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equa...

diff --git a/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 b/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724
new file mode 100644 (file)
index 0000000..f65e25d
--- /dev/null
+++ b/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 27A1B431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Feb 2012 00:28:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id YUuSoaUIox+N for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Feb 2012 00:28:25 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 721F9431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Feb 2012 00:28:25 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 8464A68055; Sat,  4 Feb 2012 10:28:23 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for\r
+       test_expect_equal_file\r
+In-Reply-To: <87sjishv3e.fsf@gmail.com>\r
+References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 04 Feb 2012 10:28:23 +0200\r
+Message-ID: <m24nv7t32w.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 08:28:26 -0000\r
+\r
+On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> > Hey, Dmitry.  I'm so sorry I sent my last email on your original patch\r
+> > before I saw this new series.  I do now like your original proposal\r
+> > better, since it shows the diff based the names the caller provides,\r
+> > which I now agree is probably the clearest and most robust solution.\r
+> > The second patch in this series could still go through, though, no\r
+> > matter what version of the change to test_expect_equal_file we go with.\r
+> > \r
+> \r
+> Actually, we can do both: check file name for consistent diff order\r
+> (from expected to actual) and use file names that the caller provides.\r
+> \r
+> What do you think?\r
+\r
++1\r
+\r
+> Regards,\r
+>   Dmitry\r
+\r
+Tomi\r