Re: [PATCH v3 00/10] Solaris support

diff --git a/f9/56c356080d9ee0e1aadd092125f0202f16d90b b/f9/56c356080d9ee0e1aadd092125f0202f16d90b
new file mode 100644 (file)
index 0000000..99c6e5d
--- /dev/null
+++ b/f9/56c356080d9ee0e1aadd092125f0202f16d90b
@@ -0,0 +1,97 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8B8F1431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:55:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KO2Z0SEp6QyW for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Nov 2012 07:55:15 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1DB1E431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 07:55:15 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 7E4AA1000E2;\r
+       Thu, 15 Nov 2012 17:55:14 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Blake Jones <blakej@foo.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 00/10] Solaris support\r
+In-Reply-To: <1352859005-18631-1-git-send-email-blakej@foo.net>\r
+References: <1352859005-18631-1-git-send-email-blakej@foo.net>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 15 Nov 2012 17:55:14 +0200\r
+Message-ID: <m2haoqx3ml.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 15 Nov 2012 15:55:15 -0000\r
+\r
+On Wed, Nov 14 2012, Blake Jones wrote:\r
+\r
+> Updated based on comments from Tomi Ollila last week:\r
+>\r
+> - Cleaned up the $(INSTALL) changes in vim/Makefile.\r
+> - Fixed gen-version-script to be compliant with old "sh" implementation.\r
+\r
+Ok -- tests on linux reveal...\r
+\r
+Checking for strsep... No (will use our own instead).\r
+\r
+and\r
+\r
+Checking for standard version of asctime_r... No (will define\r
+_POSIX_PTHREAD_SEMANTICS to get it).\r
+\r
+testing...\r
+\r
+$ gcc compat/have_strsep.c\r
+compat/have_strsep.c: In function =E2=80=98main=E2=80=99:\r
+compat/have_strsep.c:7:21: error: expected identifier or =E2=80=98(=E2=80=\r
+=99 before =E2=80=98const=E2=80=99\r
+compat/have_strsep.c:9:29: error: =E2=80=98delim=E2=80=99 undeclared (first=\r
+ use in this\r
+function)\r
+compat/have_strsep.c:9:29: note: each undeclared identifier is reported\r
+only once for each function it appears in\r
+zsh: exit 1     gcc compat/have_strsep.c\r
+\r
+\r
+--- It is very easy to spot the problem ;)\r
+\r
+$ gcc compat/check_asctime.c\r
+compat/check_asctime.c: In function =E2=80=98main=E2=80=99:\r
+compat/check_asctime.c:15:5: error: too many arguments to function\r
+=E2=80=98asctime_r=E2=80=99\r
+In file included from compat/check_asctime.c:8:0:\r
+/usr/include/time.h:266:14: note: declared here\r
+zsh: exit 1     gcc compat/check_asctime.c\r
+\r
+--- the posix-semantics way uses the 2-arg format.=20\r
+\r
+The logic of the test setting in this file doesn't open to\r
+me. Why not test the same way as in getpwuid_r() case ?\r
+\r
+Tomi\r