--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C40EE431FC0\r
+ for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 08:51:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id aYFT2P7iTJHi for <notmuch@notmuchmail.org>;\r
+ Tue, 7 Aug 2012 08:51:28 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id DD6C6431FAF\r
+ for <notmuch@notmuchmail.org>; Tue, 7 Aug 2012 08:51:27 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+ id E56831002A4; Tue, 7 Aug 2012 18:51:37 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+ Michal Nazarewicz <mpn@google.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-show: add notmuch-show-auto-mark-read option\r
+In-Reply-To: <874noepwez.fsf@qmul.ac.uk>\r
+References:\r
+ <7c2931eb4d34ff78e4c73d721bc00dc60d185e6a.1344260116.git.mina86@mina86.com>\r
+ <874noepwez.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1\r
+ (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 07 Aug 2012 18:51:37 +0300\r
+Message-ID: <m2ehniog3a.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Aug 2012 15:51:28 -0000\r
+\r
+On Tue, Aug 07 2012, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> On Mon, 06 Aug 2012, Michal Nazarewicz <mpn@google.com> wrote:\r
+>> From: Michal Nazarewicz <mina86@mina86.com>\r
+>>\r
+>> Setting `notmuch-show-auto-mark-read' to nil stops notmuch-show from marking\r
+>> the message as read (by removing the unread tag). Inteded for people who\r
+>> like to mark messages read explicitly.\r
+>> ---\r
+>> emacs/notmuch-show.el | 16 +++++++++++++---\r
+>> 1 files changed, 13 insertions(+), 3 deletions(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index d318430..85a17b1 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -183,6 +183,14 @@ provided with an MLA argument nor `completing-read' input."\r
+>> notmuch-show-stash-mlarchive-link-alist))\r
+>> :group 'notmuch-show)\r
+>> \r
+>> +(defcustom notmuch-show-auto-mark-read t\r
+>> + "Whether to automatically mark message as read when it is shown. If\r
+>> +nil, message needs to be marked as read manually for instance by\r
+>> +removing the unread tag."\r
+>> + :type 'boolean\r
+>> + :group 'notmuch-show)\r
+>> +\r
+>> +\r
+>> (defmacro with-current-notmuch-show-message (&rest body)\r
+>> "Evaluate body with current buffer set to the text of current message"\r
+>> `(save-excursion\r
+>> @@ -1374,9 +1382,11 @@ current thread."\r
+>> "Are the headers of the current message visible?"\r
+>> (notmuch-show-get-prop :headers-visible))\r
+>> \r
+>> -(defun notmuch-show-mark-read ()\r
+>> - "Mark the current message as read."\r
+>> - (notmuch-show-tag-message "-unread"))\r
+>> +(defun notmuch-show-mark-read (&optional force)\r
+>> + "Mark the current message as read if FORCE or\r
+>> +`notmuch-show-auto-mark-read' is non-nil."\r
+>> + (when (or force notmuch-show-auto-mark-read)\r
+>> + (notmuch-show-tag-message "-unread")))\r
+>\r
+>\r
+> As an alternative approach would allowing a list of tags (or even tag\r
+> changes) to apply when a message is "read" do what you want and be more\r
+> flexible?\r
+\r
+That's a great idea -- better than mine (just a variable which informs\r
+which tag is to be removed) .. something like:\r
+\r
+(defcustom notmuch-message-read-tag-changes '("-unread") "docstring" ...)\r
+\r
+Then one can have e.g.\r
+\r
+'() -- for no tag changes\r
+'("-inbox" "-unread" "+read") \r
+'("-postilaatikko" "-lukematon" "+luettu") -- the above in finnish.\r
+\r
+\r
+Tomi\r
+\r
+\r
+> I am thinking of something roughly analogous to\r
+> notmuch-message-replied-tags. I can imagine some people would like to\r
+> remove the inbox tag automatically for example. (And since we sync with\r
+> maildir flags the exact tag name does matter).\r
+>\r
+> I agree with Austin that the current unread marking is a little\r
+> weird/unpredictable (eg notmuch-show-next-message marks a message read\r
+> even if it is closed) but I don't think fixing that helps your use.\r
+\r
+\r
+>\r
+> Best wishes \r
+>\r
+> Mark\r
+>\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff