Re: [PATCH] test: make test_expect_equal_file() arguments flexible

diff --git a/11/cf6225437e40556edb51d9f8202b5496cbf638 b/11/cf6225437e40556edb51d9f8202b5496cbf638
new file mode 100644 (file)
index 0000000..40145c4
--- /dev/null
+++ b/11/cf6225437e40556edb51d9f8202b5496cbf638
@@ -0,0 +1,93 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A3533431E64\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 00:47:47 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id YfsPsHnH+0bf for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 00:47:46 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id D1E60431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 00:47:46 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 378E22E50E5F;\r
+       Wed,  1 Feb 2012 00:47:44 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 746C82E50D46;\r
+       Wed,  1 Feb 2012 00:47:34 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id B9987291; Wed,  1 Feb 2012 00:47:33 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible\r
+In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 01 Feb 2012 00:47:30 -0800\r
+Message-ID: <87r4yfszx9.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 08:47:47 -0000\r
+\r
+--=-=-=\r
+\r
+On Wed,  1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> The down side of this approach is that diff argument order depends on\r
+> test_expect_equal_file() argument order.  So sometimes we get diff\r
+> from expected to actual results, and sometimes the other way around.\r
+> But the files are always named correctly.\r
+\r
+Actually, I think this last point is the most important thing to retain.\r
+Consistency in the diffs makes reading test results much more efficient.\r
+The order I don't much care about.  But seeing as we have been\r
+consistent with a particular order for a while, it seems like more\r
+effort than it's worth to change it.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPKPwjAAoJEO00zqvie6q8ptIP+wTZveaN5Cq04UsIjSi/shdL\r
+qrjvzOMMqT+gQC13PRpeFmYEklL5Xa3F9FTmyGaiEtv7dQG9GJ70ii8c7kRObZzO\r
+7DkZFu4n2o4wSmfTVBh6arX5fJbBY/1rb8nnq7SltTJ/FTaPv/C4tquQY32YKb4d\r
+jpPGWRt+zntKk4U4BE+djHGuoLO4/f5ru4ZwAPKt0AKJv2VK8IJus6gVQdG9rxDp\r
+abuAwnzc75Wy5wzi1mkyQjdFCH36GwNTZfj8Iu46PmZcDb/iPLJZ4o8aYZI47vU2\r
+KrLiNHjyg5amWoCh51YQrh16g2OpssmxZ3CA2ZcqIaAE4TSH/YDv98ZYOkCE6CLa\r
+X1JWpDrsZRbqqWOqnhU45cKJh6Iia84voloAIu0FoDwmT0VdE7SQIr3FNC6DaUJH\r
+Ygzlug7I5Sl5fVH1rMxGbnq7r716XPjhacTcfRP/daXG/8+2bSvHDqO6zhmTryaq\r
+klzGTUJF4SovfVjJmHSqJFcTT+a7r3r/7nLILIYcdDLS1xtFJO3//xMTw31tZepp\r
+/efN+0MtW3lFLl+jUvoqN7R47d5M5UHClcl81W43fC165uSoXAOidv5d5uQjpNJg\r
+IuOEzpwSrVXNE9OfXrc+WX29l46YNDOzGm2mCzTzibNnwTG7TDabWcGkdSRFbIOT\r
+70QnD6m/z19ovoaOyYcW\r
+=os7l\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r