--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 06017431FAF\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 08:11:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id oj1+PPXRHLaT for <notmuch@notmuchmail.org>;\r
+ Sun, 25 Nov 2012 08:11:16 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 05781431FAE\r
+ for <notmuch@notmuchmail.org>; Sun, 25 Nov 2012 08:11:16 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1TcenV-0004q9-Sh; Sun, 25 Nov 2012 16:11:12 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1TcenV-0001TF-FJ; Sun, 25 Nov 2012 16:11:09 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 00/20] insert command\r
+In-Reply-To: <1353806206-29133-1-git-send-email-novalazy@gmail.com>\r
+References: <1353806206-29133-1-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 25 Nov 2012 16:11:12 +0000\r
+Message-ID: <87boelk6hr.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: b9bba2258e409ee7c8124bc603f719e1 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 25 Nov 2012 16:11:18 -0000\r
+\r
+\r
+This is series is looking good. I have a few minor issues but no more.\r
+\r
+There are two parts I don't really know enough about to be certain\r
+about: the fsyncing and the sigtrap bit. \r
+\r
+For fsync: I have some recollection that you have to fsync all subpaths\r
+to the root to guarantee that it makes it to the disk. \r
+\r
+One in particular that may need more fsyncing is if you create a folder\r
+A/B/C/D/E/ for the messages then I think you only fsync the message and\r
+A/B/C/D/E/new.\r
+\r
+My other comments are all very minor and are made in individual replies.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Sun, 25 Nov 2012, Peter Wang <novalazy@gmail.com> wrote:\r
+> This series mainly addresses the issues raised by Mark:\r
+>\r
+> - check talloc failures\r
+> - deadlock in maildir_open_tmp\r
+> - stricter file modes (0600 and 0700)\r
+> - shared tag operation parser with notmuch-tag.c\r
+> - simplified mkdir_parents\r
+> - trap SIGINT\r
+> - fsync after writing and rename\r
+> - added a couple of tests\r
+> - man page wording\r
+> - comments\r
+>\r
+> Due to new restriction on tags beginning with '-', an argument beginning with\r
+> "--" is no longer ambiguous so I have removed the optional "--" separator\r
+> between options and tag operations.\r
+>\r
+> Peter Wang (20):\r
+> tag: factor out tag operation parsing\r
+> tag: make tag operation parser public\r
+> cli: add stub for insert command\r
+> insert: open Maildir tmp file\r
+> insert: copy stdin to Maildir tmp file\r
+> insert: move file from Maildir tmp to new\r
+> insert: add new message to database\r
+> insert: support --folder option\r
+> insert: prevent writes outside Maildir hierarchy\r
+> insert: apply default tags to new message\r
+> insert: parse command-line tag operations\r
+> insert: apply command-line tag operations\r
+> insert: add --create-folder option\r
+> insert: fsync after writing tmp file\r
+> insert: fsync new directory after rename\r
+> insert: trap SIGINT and clean up\r
+> insert: add copyright line from notmuch-deliver\r
+> test: add tests for insert\r
+> man: document 'insert' command\r
+> man: reference notmuch-insert.1\r
+>\r
+> Makefile.local | 1 +\r
+> man/Makefile.local | 1 +\r
+> man/man1/notmuch-config.1 | 4 +-\r
+> man/man1/notmuch-count.1 | 4 +-\r
+> man/man1/notmuch-dump.1 | 4 +-\r
+> man/man1/notmuch-insert.1 | 60 +++++\r
+> man/man1/notmuch-new.1 | 4 +-\r
+> man/man1/notmuch-reply.1 | 3 +-\r
+> man/man1/notmuch-restore.1 | 3 +-\r
+> man/man1/notmuch-search.1 | 3 +-\r
+> man/man1/notmuch-show.1 | 3 +-\r
+> man/man1/notmuch-tag.1 | 3 +-\r
+> man/man1/notmuch.1 | 3 +-\r
+> man/man5/notmuch-hooks.5 | 4 +-\r
+> man/man7/notmuch-search-terms.7 | 3 +-\r
+> notmuch-client.h | 12 +\r
+> notmuch-insert.c | 493 ++++++++++++++++++++++++++++++++++++++++\r
+> notmuch-tag.c | 79 ++++---\r
+> notmuch.c | 3 +\r
+> test/insert | 93 ++++++++\r
+> test/notmuch-test | 1 +\r
+> 21 files changed, 733 insertions(+), 51 deletions(-)\r
+> create mode 100644 man/man1/notmuch-insert.1\r
+> create mode 100644 notmuch-insert.c\r
+> create mode 100755 test/insert\r
+>\r
+> -- \r
+> 1.7.12.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff