Re: [PATCH 6/6] cli: lazily create the crypto gpg context only when needed

diff --git a/b1/4b191ea2253269170d68743aa2ee532e8006c3 b/b1/4b191ea2253269170d68743aa2ee532e8006c3
new file mode 100644 (file)
index 0000000..2668bec
--- /dev/null
+++ b/b1/4b191ea2253269170d68743aa2ee532e8006c3
@@ -0,0 +1,103 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 86580431FC2\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 15:29:56 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id DPGqdNiBvjti for <notmuch@notmuchmail.org>;\r
+       Thu, 17 May 2012 15:29:56 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+       [18.7.68.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B848431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 17 May 2012 15:29:56 -0700 (PDT)\r
+X-AuditID: 12074424-b7fae6d000000906-72-4fb57be36946\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id F6.D7.02310.3EB75BF4; Thu, 17 May 2012 18:29:55 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4HMTtC5027501; \r
+       Thu, 17 May 2012 18:29:55 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4HMTr2h011402\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 17 May 2012 18:29:54 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SV9Cj-0003V8-Ov; Thu, 17 May 2012 18:29:53 -0400\r
+Date: Thu, 17 May 2012 18:29:53 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Subject: Re: [PATCH 6/6] cli: lazily create the crypto gpg context only when\r
+       needed\r
+Message-ID: <20120517222953.GR11804@mit.edu>\r
+References: <1337205359-2444-1-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-2-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-3-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-4-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-5-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-6-git-send-email-jrollins@finestructure.net>\r
+       <1337205359-2444-7-git-send-email-jrollins@finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1337205359-2444-7-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hRV1n1cvdXfYMcRI4s9+7wsrt+cyezA\r
+       5HH3NJfHs1W3mAOYorhsUlJzMstSi/TtErgyth18yFZwha1icetR5gbGraxdjJwcEgImEvtn\r
+       b2WDsMUkLtxbD2RzcQgJ7GOU+PjgJiuEs4FRYvuednYI5ySTxOKGpUwQzhJGidst61hA+lkE\r
+       VCUm7ZoJZrMJaEhs27+cEcQWETCT6PnyB8xmFtCS2LrxA5gtLBAq8bDhA9gdvAI6Eg0zDrKD\r
+       2EAbmCU+3imHiAtKnJz5hAWm98a/l0CLOYBsaYnl/zhATE4BL4ntB1NBKkQFVCSmnNzGNoFR\r
+       aBaS5llImmchNC9gZF7FKJuSW6Wbm5iZU5yarFucnJiXl1qka66Xm1mil5pSuokRFNLsLio7\r
+       GJsPKR1iFOBgVOLhDTq12V+INbGsuDL3EKMkB5OSKO+Tyq3+QnxJ+SmVGYnFGfFFpTmpxYcY\r
+       JTiYlUR496sD5XhTEiurUovyYVLSHCxK4rwaWu/8hATSE0tSs1NTC1KLYLIyHBxKErwxwNgV\r
+       EixKTU+tSMvMKUFIM3FwggznARoeB1LDW1yQmFucmQ6RP8WoKCXO6w+SEABJZJTmwfXCUs4r\r
+       RnGgV4R5q0CqeIDpCq77FdBgJqDBZbmbQAaXJCKkpBoYu2YHSa/6s3jpRO9Cz8ci1wPP/Hp9\r
+       iG36s4C5C9OyFrhFZ74MfSW9ULLjxL2iZzZr3jC39XDEq93/FTVlQcR/0Ycrj64pc3Q4+8J+\r
+       zqLqrjf3ogMq7q/rSAx4eJgxtrfyo4JU6guLe/c7L5+4ovz1mBWbi27Gj/CrXgxTHRRdNgYc\r
+       WpE5aVJSuxJLcUaioRZzUXEiACIBGIwUAwAA\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 17 May 2012 22:29:56 -0000\r
+\r
+Quoth Jameson Graef Rollins on May 16 at  2:55 pm:\r
+> Move the creation of the crypto ctx into mime-node.c and create it\r
+> only when needed.  This removes code duplication from notmuch-show and\r
+> notmuch-reply, and should speed up these functions considerably if the\r
+> crypto flags are provided but the messages don't have any\r
+> cryptographic parts.\r
+> ---\r
+>  mime-node.c     |   25 +++++++++++++++++++++++++\r
+>  notmuch-reply.c |   19 -------------------\r
+>  notmuch-show.c  |   23 -----------------------\r
+>  3 files changed, 25 insertions(+), 42 deletions(-)\r
+> \r
+> diff --git a/mime-node.c b/mime-node.c\r
+> index 8cdabc8..7278c74 100644\r
+> --- a/mime-node.c\r
+> +++ b/mime-node.c\r
+> @@ -182,6 +182,31 @@ _mime_node_create (mime_node_t *parent, GMimeObject *part)\r
+\r
+This patch should also update the documentation comment for\r
+mime_node_open.\r