[PATCH v3 1/5] config: Fix free in 'config get' implementation.

diff --git a/fb/5b9e6c7be50530a73d8d941070de3ef6247260 b/fb/5b9e6c7be50530a73d8d941070de3ef6247260
new file mode 100644 (file)
index 0000000..bc36c7f
--- /dev/null
+++ b/fb/5b9e6c7be50530a73d8d941070de3ef6247260
@@ -0,0 +1,85 @@
+Return-Path: <novalazy@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1389E431FC3\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 18:48:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0NxMaaOGcGSX for <notmuch@notmuchmail.org>;\r
+       Thu,  5 Apr 2012 18:48:44 -0700 (PDT)\r
+Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com\r
+       [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B43CC431FC9\r
+       for <notmuch@notmuchmail.org>; Thu,  5 Apr 2012 18:48:42 -0700 (PDT)\r
+Received: by dacx6 with SMTP id x6so2370746dac.18\r
+       for <notmuch@notmuchmail.org>; Thu, 05 Apr 2012 18:48:42 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=mkSjrE63V0UO6LxveJEQlNNV/Rp+LMoxf9IM3FkxXPs=;\r
+       b=S1qiyNSM4wl7HzYsEu7cqTEcbBW8SD9NNdQ/p2oQP5QDPdc/MMkXnBR5YKJ3SNlbda\r
+       BUcuPa5kdzAG8Qzo80r/7UjYvi5nQFtLBN89YtLhu3c4ZwISg6rSQ5mYa+PJGqdTd5A7\r
+       utnSE1gwSrbZ2UfQGZSJsMk6AEQ/l3ClvFF3Kz/SU2B0auVm+Ky0ZDYFyfRN5qBCwMO6\r
+       zp1fWkTTmb1+72JLvtwBAbnnDYcf9z3CYXzhx3SEOfhk7NH+Jc4bMUG/ZCrgj0FTGN4v\r
+       6QdgWkZcwrF0DNV59qK6a+8gB8xFsSh4RdlfDVncmwthpdhCrVgmQmRKulxsOKR6wbhL\r
+       s5nA==\r
+Received: by 10.68.193.161 with SMTP id hp1mr11191271pbc.106.1333676921940;\r
+       Thu, 05 Apr 2012 18:48:41 -0700 (PDT)\r
+Received: from localhost (215.42.233.220.static.exetel.com.au.\r
+       [220.233.42.215])\r
+       by mx.google.com with ESMTPS id h10sm4776832pbh.69.2012.04.05.18.48.39\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 05 Apr 2012 18:48:40 -0700 (PDT)\r
+From: Peter Wang <novalazy@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v3 1/5] config: Fix free in 'config get' implementation.\r
+Date: Fri,  6 Apr 2012 11:48:02 +1000\r
+Message-Id: <1333676886-9835-2-git-send-email-novalazy@gmail.com>\r
+X-Mailer: git-send-email 1.7.4.4\r
+In-Reply-To: <1333676886-9835-1-git-send-email-novalazy@gmail.com>\r
+References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>\r
+       <1333676886-9835-1-git-send-email-novalazy@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Apr 2012 01:48:45 -0000\r
+\r
+The array returned by g_key_file_get_string_list() should be freed with\r
+g_strfreev(), not free().\r
+---\r
+ notmuch-config.c |    2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/notmuch-config.c b/notmuch-config.c\r
+index e9b2750..85fc774 100644\r
+--- a/notmuch-config.c\r
++++ b/notmuch-config.c\r
+@@ -751,7 +751,7 @@ notmuch_config_command_get (void *ctx, char *item)\r
+       for (i = 0; i < length; i++)\r
+           printf ("%s\n", value[i]);\r
+ \r
+-      free (value);\r
++      g_strfreev (value);\r
+     }\r
+ \r
+     notmuch_config_close (config);\r
+-- \r
+1.7.4.4\r
+\r