Re: [PATCH 1/7] Split notmuch_database_close into two functions

diff --git a/22/a9eaebe81a6f219327ffbfb7b956574d143cfc b/22/a9eaebe81a6f219327ffbfb7b956574d143cfc
new file mode 100644 (file)
index 0000000..8ec3d8a
--- /dev/null
+++ b/22/a9eaebe81a6f219327ffbfb7b956574d143cfc
@@ -0,0 +1,92 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BB6A9431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Apr 2012 14:51:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id U6rZk9h7-Koz for <notmuch@notmuchmail.org>;\r
+       Mon, 16 Apr 2012 14:51:16 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 69620431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Apr 2012 14:51:16 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (unknown [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id C9F465833F2\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Apr 2012 23:51:14 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id 14C98DF2A2; Mon, 16 Apr 2012 23:51:14 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (unknown [10.1.1.153])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested) (Authenticated sender: teythoon)\r
+       by mail.jade-hamburg.de (Postfix) with ESMTPSA id 14F4ADF2A0;\r
+       Mon, 16 Apr 2012 23:51:13 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1SJtpI-00052m-IR; Mon, 16 Apr 2012 23:51:12 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+User-Agent: alot/0.3+\r
+To: Mark Walters <markwalters1009@gmail.com>,  notmuch@notmuchmail.org\r
+References:\r
+ <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <87fwcopu5g.fsf@qmul.ac.uk>\r
+In-Reply-To: <87fwcopu5g.fsf@qmul.ac.uk>\r
+Message-ID: <20120416215112.15615.94985@thinkbox.jade-hamburg.de>\r
+Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions\r
+Date: Mon, 16 Apr 2012 23:51:12 +0200\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 16 Apr 2012 21:51:18 -0000\r
+\r
+Quoting Mark Walters (2012-03-31 19:17:15)\r
+> Secondly, I think the patch series could be made clearer and easier to\r
+> review. If you do it in three steps\r
+> =\r
+\r
+> 1) change of notmuch_database_close to notmuch_database_destroy (just\r
+>    the function name change)\r
+> 2) split the new notmuch_database_destroy into two as in the current\r
+>    first patch\r
+> 3) Make any changes (if there are any) of notmuch_database_destroy to\r
+>    notmuch_database_close.\r
+> =\r
+\r
+> The advantage is that the first change is easy to test (essentially does\r
+> it build) and then changes from notmuch_database_destroy to\r
+> notmuch_database_close in step 3 are explicit rather than the current\r
+> situation where we need to grep the code to see if some instances of\r
+> notmuch_database_close were not changed to notmuch_database_destroy.\r
+\r
+I don't buy it. The patch series first touches the library and\r
+documentation and the lib compiles fine. The next patch updates the\r
+cli tools, all of them compile fine afterwards.\r
+\r
+Every patch addresses the issue component wise, this seems rather\r
+natural for me.\r
+\r
+Cheers,\r
+Justus\r