Re: [PATCH 08/11] cli: add thread recipients to search output

diff --git a/0c/fcf8b73f8fbd990fd9dd7864ea9b0bc6dcbb55 b/0c/fcf8b73f8fbd990fd9dd7864ea9b0bc6dcbb55
new file mode 100644 (file)
index 0000000..a38e6b8
--- /dev/null
+++ b/0c/fcf8b73f8fbd990fd9dd7864ea9b0bc6dcbb55
@@ -0,0 +1,115 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B476E431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 14:00:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WJ1WEDScjP70 for <notmuch@notmuchmail.org>;\r
+       Fri, 31 Aug 2012 14:00:47 -0700 (PDT)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 19953431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 14:00:47 -0700 (PDT)\r
+Received: from localhost (unknown [192.168.200.4])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id C4A8A3CFE71;\r
+       Fri, 31 Aug 2012 23:00:42 +0200 (CEST)\r
+X-Virus-Scanned: IMAP AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id h8X4-glOLo_r; Fri, 31 Aug 2012 23:00:41 +0200 (CEST)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 53DFA19F3379;\r
+       Fri, 31 Aug 2012 23:00:41 +0200 (CEST)\r
+Received: from steelpick.2x.cz (unknown [213.29.198.144])\r
+       (Authenticated sender: sojkam1)\r
+       by imap.feld.cvut.cz (Postfix) with ESMTPSA id 3D478660904;\r
+       Fri, 31 Aug 2012 23:00:41 +0200 (CEST)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.80)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1T7YKW-0002DZ-PY; Fri, 31 Aug 2012 23:00:40 +0200\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 08/11] cli: add thread recipients to search output\r
+In-Reply-To: <1345427570-26518-9-git-send-email-jrollins@finestructure.net>\r
+References: <1345427570-26518-1-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-2-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-3-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-4-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-5-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-6-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-7-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-8-git-send-email-jrollins@finestructure.net>\r
+       <1345427570-26518-9-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.14+3~g608c52f (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 31 Aug 2012 23:00:40 +0200\r
+Message-ID: <877gseojyf.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 Aug 2012 21:00:48 -0000\r
+\r
+On Mon, Aug 20 2012, Jameson Graef Rollins wrote:\r
+> This adds a "--include-recipients" option to notmuch search.  With\r
+> structured output formats (e.g. json), a new recipients field will be\r
+> included that holds recipients of the thread.  Matched and non-matched\r
+> recipients are delineated as with authors.\r
+>\r
+> As mentioned in the previous patch for the underlying lib functions,\r
+> the need for the option is because message recipients are not stored\r
+> in the database and therefore retrieving them adds a significant\r
+> overhead.  If they were included, this option would not be necessary.\r
+> ---\r
+>  lib/notmuch.h    |    6 +++++-\r
+>  lib/query.cc     |    5 +++--\r
+>  notmuch-search.c |   14 +++++++++++---\r
+>  notmuch-show.c   |    2 +-\r
+>  test/json        |    1 -\r
+>  5 files changed, 20 insertions(+), 8 deletions(-)\r
+>\r
+> diff --git a/lib/notmuch.h b/lib/notmuch.h\r
+> index f9e71c1..8eb455e 100644\r
+> --- a/lib/notmuch.h\r
+> +++ b/lib/notmuch.h\r
+> @@ -642,6 +642,9 @@ notmuch_threads_valid (notmuch_threads_t *threads);\r
+>  \r
+>  /* Get the current thread from 'threads' as a notmuch_thread_t.\r
+>   *\r
+> + * If the include_recipients flag is TRUE, thread recipients will be\r
+> + * included in the returned thread object.\r
+> + *\r
+>   * Note: The returned thread belongs to 'threads' and has a lifetime\r
+>   * identical to it (and the query to which it belongs).\r
+>   *\r
+> @@ -652,7 +655,8 @@ notmuch_threads_valid (notmuch_threads_t *threads);\r
+>   * NULL.\r
+>   */\r
+>  notmuch_thread_t *\r
+> -notmuch_threads_get (notmuch_threads_t *threads);\r
+> +notmuch_threads_get (notmuch_threads_t *threads,\r
+> +                 notmuch_bool_t include_recipients);\r
+\r
+What about adding a new function notmuch_threds_get_with_recipients() to\r
+not break public API? It would also make the sources more readable.\r
+\r
+-M.\r