--- /dev/null
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8C408431FB6\r
+ for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 22:15:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.7\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.7 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id LAqMtJojAxur for <notmuch@notmuchmail.org>;\r
+ Thu, 18 Oct 2012 22:15:37 -0700 (PDT)\r
+Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com\r
+ [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 0373A431FAE\r
+ for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 22:15:36 -0700 (PDT)\r
+Received: by mail-vb0-f53.google.com with SMTP id fc21so81425vbb.26\r
+ for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 22:15:36 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=TG+0b7+IUvDAs6CSvkHQ4yxkmsaNavgoZKmEsptif5U=;\r
+ b=h429bfY1oOvNJ1/4D8B7Du8Nbnr2aLTK2YCa2dSTuKXMUqQkLTvpD2a/N3qarNXdWY\r
+ YNJOGv4AmZpMB5drdKz/quSswBmrd838aUHRdFlO+7sRZkQdHhAAXH7GaQjJCIrpBfKu\r
+ GccOXynkhUgCynQNMl9dc2tosFB0NWYUd7O5nIIn9xqM6zszTRNwBgVLBPPEogyC6v/H\r
+ IEYiEdMReQzzubd+5ZMgI7ZITjm3t1b17uNbYh8P72f6NIvMCLr3aNEz3p7qz/z6E9iR\r
+ 33OsvyQdE9VyHtao9vNy8N0i3eF+gHV2kLXYcXNSfasuslk6u2g3ewZjs3k+ZFqJ9K0o\r
+ eDjg==\r
+Received: by 10.52.32.1 with SMTP id e1mr120027vdi.68.1350623735992;\r
+ Thu, 18 Oct 2012 22:15:35 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+ by mx.google.com with ESMTPS id xq19sm741776veb.0.2012.10.18.22.15.34\r
+ (version=TLSv1/SSLv3 cipher=OTHER);\r
+ Thu, 18 Oct 2012 22:15:35 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t\r
+In-Reply-To: <1340198947-29370-8-git-send-email-novalazy@gmail.com>\r
+References: <1340198947-29370-1-git-send-email-novalazy@gmail.com>\r
+ <1340198947-29370-8-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 19 Oct 2012 01:15:31 -0400\r
+Message-ID: <87txtr6o0c.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 19 Oct 2012 05:15:38 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can\r
+> cover all four values of search --exclude in the cli.\r
+\r
+This series looks good to me. It's a nice clean up and a nice new\r
+feature. Patches all apply.\r
+\r
+However, I'm getting test failures like:\r
+\r
+ FAIL Search, exclude "deleted" messages from message search --exclude=false\r
+ --- excludes.3.expected 2012-10-19 04:45:06.900518377 +0000\r
+ +++ excludes.3.output 2012-10-19 04:45:06.900518377 +0000\r
+ @@ -1,2 +1,2 @@\r
+ -id:msg-001@notmuch-test-suite\r
+ id:msg-002@notmuch-test-suite\r
+ +id:msg-001@notmuch-test-suite\r
+\r
+ FAIL Search, don't exclude "deleted" messages when --exclude=flag specified\r
+ --- excludes.7.expected 2012-10-19 04:45:07.004518378 +0000\r
+ +++ excludes.7.output 2012-10-19 04:45:07.004518378 +0000\r
+ @@ -1,2 +1,2 @@\r
+ -thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)\r
+ thread:XXX 2001-01-05 [1/2] Notmuch Test Suite; Not deleted reply (deleted inbox unread)\r
+ +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)\r
+\r
+ FAIL Search, don't exclude "deleted" messages from search if not configured\r
+ --- excludes.8.expected 2012-10-19 04:45:07.028518377 +0000\r
+ +++ excludes.8.output 2012-10-19 04:45:07.028518377 +0000\r
+ @@ -1,2 +1,2 @@\r
+ -thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)\r
+ thread:XXX 2001-01-05 [2/2] Notmuch Test Suite; Deleted (deleted inbox unread)\r
+ +thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; Not deleted (inbox unread)\r
+\r
+In other words, threads and messages are coming up out of order. I'm not\r
+sure of the right way to fix this. If you would like me to try sticking\r
+"| sort" here and there in the tests I will do so. I'm not sure if the\r
+test suite is guaranteed to scan messages in a certain order.\r
+\r
+Mark Walters wrote in\r
+id:"1340198947-29370-5-git-send-email-novalazy@gmail.com" that he\r
+thought patch 1/8 seemed more intrusive than he liked. Maybe I just have\r
+a higher standard for "intrusive" than he does ;) but I thought it was\r
+fine.\r
+\r
+It looks like you have better wording for patch 4/8 so I'd like to see\r
+you resend it.\r
+\r
+> - if (query->omit_excluded != NOTMUCH_EXCLUDE_FALSE)\r
+> + if (query->omit_excluded == NOTMUCH_EXCLUDE_TRUE ||\r
+> + query->omit_excluded == NOTMUCH_EXCLUDE_ALL)\r
+> + {\r
+> final_query = Xapian::Query (Xapian::Query::OP_AND_NOT,\r
+> final_query, exclude_query);\r
+> - else {\r
+> + } else {\r
+\r
+"House style" is to not put braces around one-line then-clauses. This is\r
+the only place where you did that.\r
+\r
+I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!\r
+\r
+Ethan\r
projects / notmuch-archives.git / commitdiff