Re: [PATCH 1/2] test: emacs mailto: URI handling

diff --git a/10/73975383ce6d1a368263667236ed900024194b b/10/73975383ce6d1a368263667236ed900024194b
new file mode 100644 (file)
index 0000000..d86d100
--- /dev/null
+++ b/10/73975383ce6d1a368263667236ed900024194b
@@ -0,0 +1,93 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A0403431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id KoDjMDmB6xyX for <notmuch@notmuchmail.org>;\r
+       Mon, 15 Oct 2012 10:12:08 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A10C5431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:08 -0700 (PDT)\r
+Received: by mail-qc0-f181.google.com with SMTP id x40so4820367qcp.26\r
+       for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 10:12:08 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=kGBkaDph+R6AE03TuTZwYu6VSGhYX9zXYOtvflAl4dg=;\r
+       b=wGKBwVe5qezSjb8c2WTwQH9kagDllaJZS89NmtNSvp/Teyk4b+BQ3i1Zx516KGOr+4\r
+       9PDu9+7aF+/4kdP0kMxWjj9FSTo0XId2+Ntz5c9QBfElL1oYcpx9p7AzekvvDHXIN4bB\r
+       jFyxq7ALRZRrl2FmV1ybDJX9jiCyBNW7BVBkLvKGrBvSebJo6XUldWMB8OvnItaRDHtL\r
+       ipG/LpmK1jT7VQIL4FeH1HRWQjjAKncnEKkq/viQ7HXl6oAkcXSoto+gS1xhfW0qq49R\r
+       0ooey+mOmqFJyqsN6N3P+peh5T9keX/9b+dw9AVuoH6RqRI4T1zm0wyGG/iRpqbJruVY\r
+       IzWg==\r
+Received: by 10.224.31.204 with SMTP id z12mr12704102qac.32.1350321127827;\r
+       Mon, 15 Oct 2012 10:12:07 -0700 (PDT)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id hk10sm7707580qab.22.2012.10.15.10.12.05\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 15 Oct 2012 10:12:06 -0700 (PDT)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 1/2] test: emacs mailto: URI handling\r
+In-Reply-To: <1327865624-7673-1-git-send-email-jrollins@finestructure.net>\r
+References: <1327865624-7673-1-git-send-email-jrollins@finestructure.net>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 15 Oct 2012 13:12:04 -0400\r
+Message-ID: <877gqracd7.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 15 Oct 2012 17:12:10 -0000\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+\r
+> This adds a test for proposed rfc6068 "mailto:" URI handling.  The\r
+> proposed function would be called 'notmuch-mua-mailto'.  The test\r
+> provides an example mailto: string that should test some subset of the\r
+> rfc6068 specification: http://tools.ietf.org/html/rfc6068\r
+\r
+Hi! Just going through the patch queue. This test, at least, looks\r
+sane, so why not apply it?\r
+\r
+As for the mailto: handler itself, you wrote in\r
+id:"87vcin2fo6.fsf@servo.finestructure.net" that you would add something\r
+to the next version, thereby implying that there would be a next\r
+version. Do you still intend to release such a new version soon? I would\r
+love to review it. This version looks fine to me, with one minor concern.\r
+\r
+> +       ;; FIXME: need to decode all html encodings in uri.\r
+> +       (mailto (replace-regexp-in-string "&amp;" "&" mailto))\r
+\r
+This is odd. Shouldn't the navigator be decoding all that stuff while\r
+parsing, before you even get to it? How often do you get mailto links\r
+with &amp; in them? You obviously wouldn't have put it in there if it\r
+weren't necessary.\r
+\r
+I would be +1 on merging this patch or the next version.\r
+\r
+Ethan\r