Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

diff --git a/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced b/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced
new file mode 100644 (file)
index 0000000..d927d70
--- /dev/null
+++ b/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced
@@ -0,0 +1,86 @@
+Return-Path: <ethan.glasser.camp@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BE603431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 20:12:46 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Xdm7JVMHm1Oh for <notmuch@notmuchmail.org>;\r
+       Mon,  5 Nov 2012 20:12:45 -0800 (PST)\r
+Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com\r
+       [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3D6F7431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  5 Nov 2012 20:12:45 -0800 (PST)\r
+Received: by mail-vc0-f181.google.com with SMTP id n11so14243vch.26\r
+       for <notmuch@notmuchmail.org>; Mon, 05 Nov 2012 20:12:44 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=LiFV/9cDsFRudng+09arYVzDkRAz+0YNQtpYFBXy+7w=;\r
+       b=ns1mapmLqXExWXAsFQvB7AU8L5MVYtFXg3yr4fFCc5wfE+gT68TJ5tBj3ycEmylWr0\r
+       syIyuR034HuchIX2gu9OgqAm3Ci4Mn7tkTHDpb/dfBDmWK4cXkhM4UqnxKuwsvwIL6a8\r
+       2qzhGKDoeFpfESeDSewppxz1OTUY3ts5vh1CV5WcMPWr7ke5egtfa+zlQ+x8YXSx1eyW\r
+       U7ecRC7qYgXTulbr+RHqmO5f6WA9ovwtQh5YCxt6rZwvPxFHNuH3//U7Vw6U2UrJUs1s\r
+       z6iK/NLwAwgGYn3t4zHgajl03pYgP6PZvCcEAKyedee4T7KlR9Y7uEFsFx9HYHCdl9X8\r
+       paaA==\r
+Received: by 10.52.173.34 with SMTP id bh2mr10167796vdc.73.1352175164567;\r
+       Mon, 05 Nov 2012 20:12:44 -0800 (PST)\r
+Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])\r
+       by mx.google.com with ESMTPS id zx18sm9362259veb.3.2012.11.05.20.12.43\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 05 Nov 2012 20:12:44 -0800 (PST)\r
+From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to\r
+       know\r
+In-Reply-To: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 05 Nov 2012 23:12:39 -0500\r
+Message-ID: <87390nid3c.fsf@betacantrips.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 06 Nov 2012 04:12:46 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> Added FILE, notmuch_show_params_t and sprinter_t to be\r
+> types when uncrustifying sources. This affect spacing\r
+> when uncrustify is deciding for type declaration instead\r
+> of binary multiplication operation.\r
+\r
+This looks good to me. If you had plenty of time and no more patches to\r
+review, I'd prefer the slightly cleaner English:\r
+\r
+This affects how uncrustify puts spacing around pointers to these types,\r
+since it can parse them as type declarations instead of binary\r
+multiplication operations.\r
+\r
+\r
+... but even suggesting this indicates I've moved past the bike shed and\r
+into somebody else's kitchen.\r
+\r
+Ethan\r