Re: [PATCH 0/9] Fix directory lookup on read-only databases

diff --git a/37/37491d017b5434311ee81cae8e1db0838d3286 b/37/37491d017b5434311ee81cae8e1db0838d3286
new file mode 100644 (file)
index 0000000..cefb170
--- /dev/null
+++ b/37/37491d017b5434311ee81cae8e1db0838d3286
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E36B3431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 22 May 2012 13:48:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.274\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.274 tagged_above=-999 required=5\r
+       tests=[RDNS_NONE=1.274] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id LxOgpesY2OUT for <notmuch@notmuchmail.org>;\r
+       Tue, 22 May 2012 13:48:01 -0700 (PDT)\r
+Received: from guru.guru-group.fi (unknown [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2D8E9431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 22 May 2012 13:48:01 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 462A9100641; Tue, 22 May 2012 23:48:00 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases\r
+In-Reply-To: <1337314423-3702-1-git-send-email-amdragon@mit.edu>\r
+References: <1337314423-3702-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13~rc1+40~g96c989b (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 22 May 2012 23:48:00 +0300\r
+Message-ID: <m2aa10uem7.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 22 May 2012 20:48:03 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> This fixes notmuch_database_get_directory and\r
+> notmuch_database_find_message_by_filename so that they don't attempt\r
+> to create missing directory documents.  This makes them work on\r
+> read-only databases (and prevents n_d_f_m_b_f from crashing\r
+> unceremoniously on read-only databases).\r
+>\r
+> Unfortunately, there are several functions involved in directory\r
+> document lookup, so the first three patches simply add a creation flag\r
+> at each necessary layer.  The remaining patches then fix up the two\r
+> API functions and their uses.\r
+>\r
+> If we do a 0.13.1 bug fix release, these patches could go in to\r
+> complement the API changes made in 0.13 to support these fixes.  David\r
+> can make that call.\r
+>\r
+> There are several patches, but they're all short and incremental.\r
+\r
+This patch series looks good to me...\r
+\r
+\r
+Tomi\r
+\r
+\r
+>\r
+>  bindings/python/notmuch/database.py |   11 -----------\r
+>  lib/database.cc                     |   40 +++++++++++++++++++++++++---------------\r
+>  lib/directory.cc                    |   41 +++++++++++++++++++++++++++++++++++------\r
+>  lib/message.cc                      |   11 +++++------\r
+>  lib/notmuch-private.h               |   13 +++++++++++++\r
+>  lib/notmuch.h                       |   10 ++--------\r
+>  notmuch-new.c                       |   36 +++++++-----------------------------\r
+>  test/python                         |    8 ++++++++\r
+>  8 files changed, 95 insertions(+), 75 deletions(-)\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r