Re: [PATCH] lib: work around talloc_steal usage from C++ code

diff --git a/8c/0869090898445e2f54c44c324de45e18d562ce b/8c/0869090898445e2f54c44c324de45e18d562ce
new file mode 100644 (file)
index 0000000..931b211
--- /dev/null
+++ b/8c/0869090898445e2f54c44c324de45e18d562ce
@@ -0,0 +1,66 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A1EF5431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 05:45:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id SXJEy3YSMKLz for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Apr 2012 05:45:17 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7A690431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Apr 2012 05:45:17 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SJOpL-0008Rp-PS; Sun, 15 Apr 2012 09:45:16 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SJOpG-0004Ca-Fk; Sun, 15 Apr 2012 09:45:06 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: work around talloc_steal usage from C++ code\r
+In-Reply-To: <1334264259-17632-1-git-send-email-jani@nikula.org>\r
+References: <1334264259-17632-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 15 Apr 2012 09:45:06 -0300\r
+Message-ID: <87k41htb8t.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Apr 2012 12:45:21 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> Implicit typecast from 'void *' to 'T *' is okay in C, but not in\r
+> C++. In talloc_steal, an explicit cast is provided for type safety in\r
+> some GCC versions. Otherwise, a cast is required. Provide a template\r
+> function for this to maintain type safety, and redefine talloc_steal\r
+> to use it.\r
+\r
+pushed,\r
+\r
+d\r