net-im/pidgin: disable single faulty jid test case, bug #593338
authorSergei Trofimovich <slyfox@gentoo.org>
Wed, 26 Dec 2018 12:57:40 +0000 (12:57 +0000)
committerSergei Trofimovich <slyfox@gentoo.org>
Wed, 26 Dec 2018 12:57:40 +0000 (12:57 +0000)
Testcase fails on all platform for a few years.
It's not a stable blocker. Let's disable it downstream
until it's fixed upstream.

Bug: https://bugs.gentoo.org/666858
Bug: https://bugs.gentoo.org/593338
Package-Manager: Portage-2.3.52, Repoman-2.3.12
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
net-im/pidgin/files/pidgin-2.13.0-disable-one-jid-test.patch [new file with mode: 0644]
net-im/pidgin/pidgin-2.13.0.ebuild

diff --git a/net-im/pidgin/files/pidgin-2.13.0-disable-one-jid-test.patch b/net-im/pidgin/files/pidgin-2.13.0-disable-one-jid-test.patch
new file mode 100644 (file)
index 0000000..cf3a6de
--- /dev/null
@@ -0,0 +1,24 @@
+https://bugs.gentoo.org/593338
+
+Workaround one failing test. test fails on all platforms.
+Needs to be fixed upstream.
+
+--- a/libpurple/tests/test_jabber_jutil.c
++++ b/libpurple/tests/test_jabber_jutil.c
+@@ -144,7 +144,16 @@ START_TEST(test_jabber_id_new)
+        *  string MUST NOT contain any LCat character."
+        * The character is U+066D (ARABIC FIVE POINTED STAR).
+        */
++#if 0
++      /*
++              Fails in gentoo: https://bugs.gentoo.org/593338
++
++              98%: Checks: 87, Failures: 1, Errors: 0
++              test_jabber_jutil.c:147:F:JID validate:test_jabber_id_new:0: JID 'foo@example.com/٭simplexe٭' is invalid but jabber_id_new() allowed it
++              FAIL check_libpurple (exit status: 1)
++      */
+       assert_invalid_jid("foo@example.com/٭simplexe٭");
++#endif
+ 
+       /* Ensure that jabber_id_new is properly lowercasing node and domains */
+       assert_jid_parts("paul", "darkrain42.org", "PaUL@darkrain42.org");
index 5a4e20069c8d74ae250ab76016ef14bd7fd947b5..68fc76b0cb0e73edb43db8ee81078ba54f95c372 100644 (file)
@@ -144,6 +144,7 @@ PATCHES=(
        "${FILESDIR}/${PN}-2.10.10-eds-3.6-configure.ac.patch"
        "${FILESDIR}/${PN}-2.10.11-tinfo.patch"
        "${DISTDIR}/${PN}-2.10.9-irc_join_sleep.patch" # 577286
+       "${FILESDIR}/${PN}-2.13.0-disable-one-jid-test.patch" # 593338
 )
 
 pkg_setup() {
@@ -263,7 +264,8 @@ src_install() {
 }
 
 src_test() {
-       emake check
+       # make default build logs slightly more useful
+       emake check VERBOSE=1
 }
 
 pkg_preinst() { gnome2_icon_savelist; }