Re: [Patch v8 01/18] parse_tag_line: use enum for return value.

diff --git a/41/8a75ccb6d924bfd7309bf12d024f8387715d6b b/41/8a75ccb6d924bfd7309bf12d024f8387715d6b
new file mode 100644 (file)
index 0000000..b87e57a
--- /dev/null
+++ b/41/8a75ccb6d924bfd7309bf12d024f8387715d6b
@@ -0,0 +1,89 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A37A0431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 22 Dec 2012 13:48:10 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3m4PYjHoww4G for <notmuch@notmuchmail.org>;\r
+       Sat, 22 Dec 2012 13:48:10 -0800 (PST)\r
+Received: from mail-la0-f54.google.com (mail-la0-f54.google.com\r
+       [209.85.215.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E6FE7431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 22 Dec 2012 13:48:09 -0800 (PST)\r
+Received: by mail-la0-f54.google.com with SMTP id j13so7020771lah.13\r
+       for <notmuch@notmuchmail.org>; Sat, 22 Dec 2012 13:48:08 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=x-received:from:to:cc:subject:in-reply-to:references:user-agent\r
+       :date:message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=m61PjPgz92RfiDqV13kE7zV0/EWkd8je1D1k6YzcTGM=;\r
+       b=Jz/SiXepwQjg0E1ZVJuOkY7Grxq4XvjX7CRsuXicvUMjEZdLH/JCr5Uzfq2UHnCSbd\r
+       wSSC6JDjTpsbRMGhuHTjihRAPdfUhpZIVRVe78U7nXfKGnPHfPJ5yRJqjme0pYzhN77K\r
+       FHdms07A4C/OCu3y2/2PeXBpmgU8pPN0e6iC8cipD6YlRfLO4q+ZM3n6pXreA7XRE71R\r
+       aHKAwM4GZ1vD6dHHIzRVvVciiLa62cQbH0AHRVTqRfBaX671WlGsvCel4BBkpTW+L+qE\r
+       bnRMg7kH+kQZZXQu2pBRhQhBeZBIgerhXFlOIL/jAzVP0sPsfd68goukgI+UiYgcjWN8\r
+       dMew==\r
+X-Received: by 10.152.132.137 with SMTP id ou9mr16391350lab.7.1356212888331;\r
+       Sat, 22 Dec 2012 13:48:08 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi.\r
+       [80.223.81.27])\r
+       by mx.google.com with ESMTPS id gr12sm6094110lab.3.2012.12.22.13.48.06\r
+       (version=SSLv3 cipher=OTHER); Sat, 22 Dec 2012 13:48:07 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v8 01/18] parse_tag_line: use enum for return value.\r
+In-Reply-To: <1356095307-22895-1-git-send-email-david@tethera.net>\r
+References: <1356095307-22895-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+211~gc8d6546 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 22 Dec 2012 23:48:04 +0200\r
+Message-ID: <87zk15hi7f.fsf@oiva.home.nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Gm-Message-State:\r
+ ALoCoQnMj1DIziDAmpEIDyfHqeO61oaUgnk2y8JK9eMPLVuPnAMjaK5dj2+oHS2z6nRdWhGhp+yj\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 22 Dec 2012 21:48:10 -0000\r
+\r
+On Fri, 21 Dec 2012, david@tethera.net wrote:\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> This is essentially cosmetic, since success=0 is promised by\r
+> the comments in tag-utils.h.\r
+\r
+Squash this on top for completeness:\r
+\r
+diff --git a/tag-util.c b/tag-util.c\r
+index 12aab08..17d7ac2 100644\r
+--- a/tag-util.c\r
++++ b/tag-util.c\r
+@@ -47,7 +47,7 @@ parse_tag_line (void *ctx, char *line,\r
+     line_for_error = talloc_strdup (ctx, line);\r
+     if (line_for_error == NULL) {\r
+       fprintf (stderr, "Error: out of memory\n");\r
+-      return -1;\r
++      return TAG_PARSE_OUT_OF_MEMORY;\r
+     }\r
+ \r
+     /* remove leading space */\r