toolchain.eclass: cleanup create_revdep_rebuild_entry()
authorSergei Trofimovich <slyfox@gentoo.org>
Sun, 25 Aug 2019 21:26:21 +0000 (22:26 +0100)
committerSergei Trofimovich <slyfox@gentoo.org>
Sun, 25 Aug 2019 21:29:12 +0000 (22:29 +0100)
From #gentoo-toolchain:
"""
<+[Arfrever]> It will cause that empty /etc/revdep-rebuild directory
              will be installed by gcc. Please move dodir to after
              'is_crosscompile || return 0'.
<+[Arfrever]> ${revdep_rebuild_file} should be quoted.
"""

Reported-by: Arfrever Frehtes Taifersar Arahesis
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
eclass/toolchain.eclass

index 156ec3d0cf88ba8a2c37842afa95157cc73ed45f..529c12a4116a3a0d673c93cc11c625922a7e2ed8 100644 (file)
@@ -2140,13 +2140,13 @@ create_gcc_env_entry() {
 }
 
 create_revdep_rebuild_entry() {
-       dodir /etc/revdep-rebuild
        local revdep_rebuild_base="/etc/revdep-rebuild/05cross-${CTARGET}-${GCC_CONFIG_VER}"
        local revdep_rebuild_file="${ED}${revdep_rebuild_base}"
 
        is_crosscompile || return 0
 
-       cat <<-EOF > ${revdep_rebuild_file}
+       dodir /etc/revdep-rebuild
+       cat <<-EOF > "${revdep_rebuild_file}"
        # Generated by ${CATEGORY}/${PF}
        # Ignore libraries built for ${CTARGET}, https://bugs.gentoo.org/692844.
        SEARCH_DIRS_MASK="${LIBPATH}"