--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 317C2431FBC\r
+ for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 04:41:55 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id xs4c041P7VDE for <notmuch@notmuchmail.org>;\r
+ Wed, 14 Nov 2012 04:41:54 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 8D058431FAF\r
+ for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 04:41:54 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1TYcHq-0004ph-3Y; Wed, 14 Nov 2012 12:41:46 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1TYcHp-00054o-Or; Wed, 14 Nov 2012 12:41:45 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Damien Cassou <damien.cassou@gmail.com>,\r
+ notmuch mailing list <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links\r
+In-Reply-To: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com>\r
+References: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+ (i486-pc-linux-gnu)\r
+Date: Wed, 14 Nov 2012 12:41:44 +0000\r
+Message-ID: <878va4xson.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 6a3e55d12f903cfd16324f16569f6d36 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Nov 2012 12:41:55 -0000\r
+\r
+\r
+Hi\r
+\r
+I have read this patch and am broadly happy with it. In particular I do\r
+not think I have any "design concerns" with this version: I think\r
+picking the tags from the visible messages is fine and this version\r
+avoids the query and the thread-id stuff.\r
+\r
+On the loading library issues I defer to Adam and Tomi.\r
+\r
+I do have a couple of comments on the current version\r
+though. First the patch is very big. I would prefer it split into\r
+several pieces something like:\r
+\r
+1) Add tags to the headerline but not clickable \r
+2) Add the header-button library if appropriate\r
+3) Add notmuch-tagger and change headerline to buttonize the tags\r
+4) Add the tests.\r
+\r
+The first would be small and uncontroversial I think, for the second it\r
+would not really be code review just "do we want to do it this way" as\r
+is being discussed in the other thread. The third obviously has the meat\r
+of the series and 4 is relatively innocuous.\r
+\r
+Possibly you could also split the add clickable buttons to tags in the\r
+buffer and add clickable buttons to headerline tags as two separate\r
+steps.\r
+\r
+One advantage of the split is that it would be easy to see who had\r
+reviewed which bits. For example I have not read the\r
+header-button-library bit or the tests but have looked at the rest.\r
+\r
+\r
+My other comment is on your comments in notmuch-tagger\r
+\r
+> +(defun notmuch-tagger-present-tags (tags &optional headerline)\r
+> + "Return a property list which nicely presents all TAGS.\r
+> +\r
+> +If HEADERLINE is non-nil the returned list will be ready for\r
+> +inclusion in the buffer's header-line. HEADERLINE must be nil in\r
+> +all other cases."\r
+\r
+I find it odd to say what it returns if HEADERLINE is non-nil and then\r
+say otherwise HEADERLINE must be nil. Could you say what it returns in\r
+the nil case? Something along them lines of\r
+\r
+"if HEADERLINE is non-nil the returned will be ready for inclusion in\r
+the buffer's header-line (i.e., will use header-buttons if\r
+available). Otherwise it returns a list?? ready for inclusion in a\r
+buffer."\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
projects / notmuch-archives.git / commitdiff