Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

diff --git a/97/63612041d4d848920a77f08e40900abbaa0a1f b/97/63612041d4d848920a77f08e40900abbaa0a1f
new file mode 100644 (file)
index 0000000..417e2b4
--- /dev/null
+++ b/97/63612041d4d848920a77f08e40900abbaa0a1f
@@ -0,0 +1,134 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E41C3431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Nov 2012 15:27:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id piMpu8N-EZ5A for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Nov 2012 15:27:30 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0ED93431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Nov 2012 15:27:30 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 5351610010B;\r
+       Sun, 25 Nov 2012 01:27:28 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: david@tethera.net, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging\r
+       routines\r
+In-Reply-To: <1353792017-31459-10-git-send-email-david@tethera.net>\r
+References: <1353792017-31459-1-git-send-email-david@tethera.net>\r
+       <1353792017-31459-10-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 25 Nov 2012 01:27:28 +0200\r
+Message-ID: <m2wqxaintr.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Nov 2012 23:27:34 -0000\r
+\r
+On Sat, Nov 24 2012, david@tethera.net wrote:\r
+\r
+> From: David Bremner <bremner@debian.org>\r
+>\r
+> These are meant to be shared between notmuch-tag and notmuch-restore.\r
+>\r
+> The bulk of the routines implement a "tag operation list" abstract\r
+> data type act as a structured representation of a set of tag\r
+> operations (typically coming from a single tag command or line of\r
+> input).\r
+> ---\r
+\r
+dumping all except beginning of tag-util.h...\r
+\r
+>  tag-util.h     |  120 ++++++++++++++++++++++++++\r
+> diff --git a/tag-util.h b/tag-util.h\r
+> new file mode 100644\r
+> index 0000000..508806f\r
+> --- /dev/null\r
+> +++ b/tag-util.h\r
+> @@ -0,0 +1,120 @@\r
+> +#ifndef _TAG_UTIL_H\r
+> +#define _TAG_UTIL_H\r
+> +\r
+> +#include "notmuch-client.h"\r
+> +\r
+> +typedef struct _tag_operation_t tag_operation_t;\r
+> +typedef struct _tag_op_list_t tag_op_list_t;\r
+> +\r
+> +#define TAG_OP_LIST_INITIAL_SIZE 10\r
+> +\r
+> +/* Use powers of 2 */\r
+> +typedef enum  { TAG_FLAG_NONE = 0,\r
+> +            /* Operations are synced to maildir, if possible */\r
+> +\r
+> +            TAG_FLAG_MAILDIR_SYNC = 1,\r
+> +\r
+> +            /* Remove all tags from message before applying\r
+> +             * list */\r
+> +\r
+> +            TAG_FLAG_REMOVE_ALL = 2,\r
+> +\r
+> +            /* Don't try to avoid database operations.  Useful\r
+> +             * when we know that message passed needs these\r
+> +             *  operations. */\r
+> +\r
+> +            TAG_FLAG_PRE_OPTIMIZED = 4,\r
+> +\r
+> +            /* Accept strange tags that might be user error;\r
+> +               intended for use by notmuch-restore.\r
+> +            */\r
+> +\r
+> +            TAG_FLAG_BE_GENEROUS = 8} tag_op_flag_t;\r
+> +\r
+\r
+Maybe something like the following formatted and consistency-tuned version:\r
+\r
+typedef enum { \r
+   TAG_FLAG_NONE = 0,\r
+\r
+   /* Operations are synced to maildir, if possible.\r
+    */\r
+   TAG_FLAG_MAILDIR_SYNC = (1 << 0),\r
+\r
+   /* Remove all tags from message before applying list.\r
+    */\r
+   TAG_FLAG_REMOVE_ALL = (1 << 1),\r
+\r
+   /* Don't try to avoid database operations. Useful when we\r
+    * know that message passed needs these operations.\r
+    */\r
+   TAG_FLAG_PRE_OPTIMIZED = (1 << 2),\r
+\r
+   /* Accept strange tags that might be user error;\r
+    * intended for use by notmuch-restore.\r
+    */\r
+   TAG_FLAG_BE_GENEROUS = (1 << 3)\r
+\r
+} tag_op_flag_t;\r
+\r
+Tomi\r