Re: [PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer...

diff --git a/d2/48bc2b00a14d39276da41e0900f44829d20481 b/d2/48bc2b00a14d39276da41e0900f44829d20481
new file mode 100644 (file)
index 0000000..30866a4
--- /dev/null
+++ b/d2/48bc2b00a14d39276da41e0900f44829d20481
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F0A45431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 23:39:58 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Q8ZuqiAqOgb8 for <notmuch@notmuchmail.org>;\r
+       Wed, 21 Nov 2012 23:39:58 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id D3DCB431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 21 Nov 2012 23:39:57 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1443010010B;\r
+       Thu, 22 Nov 2012 09:39:55 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 2/2] notmuch-show.el: handle the case where\r
+       icalendar-import-buffer returns nil\r
+In-Reply-To: <87sj82wb0f.fsf@zancas.localnet>\r
+References: <1352376480-29961-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1352376480-29961-3-git-send-email-tomi.ollila@iki.fi>\r
+       <87sj82wb0f.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 22 Nov 2012 09:39:54 +0200\r
+Message-ID: <m2liduqe5x.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 22 Nov 2012 07:39:59 -0000\r
+\r
+On Thu, Nov 22 2012, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> icalendar-import-buffer can fail by an error signal (which have been\r
+>> witnessed) but according to its docstring it can also return nil\r
+>> when failing (it returns t when succeeding).\r
+>>\r
+>> Now that the error is caught by the caller of notmuch-show-inset-part-*\r
+>> functions in case icalendar-import-buffer returns nil an explicit\r
+>> error is signaled and unwind-protect takes care of deleting the\r
+>> temporary file (just in case, it is usually not written to the fs yet).\r
+>\r
+> This one looks OK to me too, although the API that makes it necessary\r
+> out to be taken out back...\r
+\r
+I didn't quite understand the meaning of the last words...\r
+\r
+Anyway, the point in this patch is that if icalendar-import-buffer (or\r
+the older version using icalendar private functions) fail by returning\r
+nil, the error case is not (and has not been) shown to the user (user\r
+gets either empty or partially filled bodypart.\r
+\r
+Now that we would have that condition-case in the caller this code can \r
+signal error message to the user and provide info where more information\r
+can be obtained (*ical-errors* buffer).\r
+\r
+More complex code could be used to make \r
+notmuch-show-insert-part-text/calendar return nil in case \r
+icalendar-import-buffer fails -- then \r
+notmuch-show-insert-bodypart-internal would attempt to use\r
+next handler in chain to insert content (if any)\r
+\r
+>\r
+> d\r
+\r
+Tomi\r
+\r
+\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r